-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor update to Resources page #588
Comments
We shouldn't manually remove this from the @matentzn as you managed the code that generates this file, can you suggest an approach to removing monarch-app from projects that get included? |
Can someone explain why we should remove the app? So far, this list is a list of all Monarch flagship products. If we remove it the entire code needs to change - either the App is a Flagship product, and is listed on this page, or its not a flagship product and then ok, we can remove it easily.. |
Remember that |
as we have it now, the website itself is the app, which comprises 3 main parts: the python library, the fast API backend, and the Vue typescript frontend interface, at least that's been my understanding so far as for whether it is or isn't considered a flagship product, I can't really say |
Things have changed now due to the PI meeting, please put on hold until further notice. |
Did the recent changes to monarch-documentation address this? |
Minor detail was missing: monarch-initiative/monarch-documentation#65 I think we need to revisit a bit the display of that page. (I am assuming you are using https://github.com/monarch-initiative/monarch-documentation/blob/main/src/docs/resources/monarch-app-resources.json not the yaml file) We now have 6 Flagship products. 1 standard, 3 ontologies and 2 tools. These are less then there were before. We should decide if we:
OR:
Maybe you have another idea? For now, just so we can get this first pass out the door, maybe just update the page with the new content, and then we iterate with @monicacecilia advice. |
No particular ideas one way or another, I'm happy to let leadership advice and as you say, just pull it in as is for now. I've tagged you for review on #628 does just that, you can check the preview to see how it'll look on the site |
Perhaps for this first pass, we simply remove the three categories and just list the flagship products on the page. It looks a bit odd in the preview on #628 to keep them in categories when there are fewer things listed. Then we can iterate more later with more input as you both are suggesting. |
Thanks @sagehrke |
3/3 sounds good to me personally; I would suggest we focus on on content for now - display is likely to be fine tuned later. |
I agree - the 3 on each row works good for this first revision @glass-ships -- you can call this done for now! |
Request from @monicacecilia
The text was updated successfully, but these errors were encountered: