Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to Resources page #588

Closed
sagehrke opened this issue Feb 9, 2024 · 12 comments · Fixed by #628
Closed

Minor update to Resources page #588

sagehrke opened this issue Feb 9, 2024 · 12 comments · Fixed by #628
Assignees

Comments

@sagehrke
Copy link
Member

sagehrke commented Feb 9, 2024

Request from @monicacecilia

  • On the Resources page https://monarchinitiative.org/resources, we should remove the App.
  • Somewhere, probably the 'About' page we should clarify what the Monarch App is.
    • I see links to the Source documentation as well as the API
    • @monicacecilia can you clarify what you'd like clarified on the About page? 😄
@sagehrke sagehrke added this to the 2024-03 Release milestone Feb 9, 2024
@glass-ships
Copy link
Collaborator

We shouldn't manually remove this from the resources.json, since that file is generated from monarch-documentation.

@matentzn as you managed the code that generates this file, can you suggest an approach to removing monarch-app from projects that get included?

@matentzn
Copy link
Member

Can someone explain why we should remove the app? So far, this list is a list of all Monarch flagship products. If we remove it the entire code needs to change - either the App is a Flagship product, and is listed on this page, or its not a flagship product and then ok, we can remove it easily..

@matentzn
Copy link
Member

Remember that mi.org !=App the App is a part of mi.org. mi.org is our Portal, which gives access to multiple apps and products!

@glass-ships
Copy link
Collaborator

glass-ships commented Feb 15, 2024

as we have it now, the website itself is the app, which comprises 3 main parts: the python library, the fast API backend, and the Vue typescript frontend interface, at least that's been my understanding so far

as for whether it is or isn't considered a flagship product, I can't really say

@matentzn
Copy link
Member

Things have changed now due to the PI meeting, please put on hold until further notice.

@sagehrke sagehrke removed this from the 2024-03 Release milestone Feb 20, 2024
@glass-ships
Copy link
Collaborator

Did the recent changes to monarch-documentation address this?
(ie. Is the current version of monarch-documentation/.../resources.yaml accurate, if i were to pull it into the app now?)

@matentzn
Copy link
Member

matentzn commented Mar 7, 2024

Minor detail was missing: monarch-initiative/monarch-documentation#65

I think we need to revisit a bit the display of that page. (I am assuming you are using https://github.com/monarch-initiative/monarch-documentation/blob/main/src/docs/resources/monarch-app-resources.json not the yaml file)

We now have 6 Flagship products. 1 standard, 3 ontologies and 2 tools. These are less then there were before. We should decide if we:

  1. Just want to show the flagship products in one row at the top so they are visible at first glance and then
  2. Show all the core products listed underneath, broken down by tool, ontology and standard

OR:

  1. we break down the page by tool, ontology and standard to start with and somehow show
  2. The flagship products first, clearly indicated as such and then all the other "Core products"

Maybe you have another idea?

For now, just so we can get this first pass out the door, maybe just update the page with the new content, and then we iterate with @monicacecilia advice.

@glass-ships
Copy link
Collaborator

No particular ideas one way or another, I'm happy to let leadership advice and as you say, just pull it in as is for now. I've tagged you for review on #628 does just that, you can check the preview to see how it'll look on the site

@sagehrke
Copy link
Member Author

sagehrke commented Mar 7, 2024

Perhaps for this first pass, we simply remove the three categories and just list the flagship products on the page. It looks a bit odd in the preview on #628 to keep them in categories when there are fewer things listed.

Then we can iterate more later with more input as you both are suggesting.

@glass-ships
Copy link
Collaborator

Thanks @sagehrke
I'm not sure we can squeeze all 6 in one row, at best it'd be 5 on top row and 1 in a second row.
For now I've condensed it to one section, but still having it 3 items for each row.
Let me know if that's ok for now.

@matentzn
Copy link
Member

matentzn commented Mar 8, 2024

3/3 sounds good to me personally; I would suggest we focus on on content for now - display is likely to be fine tuned later.

@sagehrke
Copy link
Member Author

sagehrke commented Mar 8, 2024

I agree - the 3 on each row works good for this first revision @glass-ships -- you can call this done for now!

glass-ships added a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants