Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes from team meeting on 12/16/2022 #77

Closed
vincerubinetti opened this issue Dec 21, 2022 · 2 comments · Fixed by #288
Closed

Notes from team meeting on 12/16/2022 #77

vincerubinetti opened this issue Dec 21, 2022 · 2 comments · Fixed by #288
Assignees
@vincerubinetti @putmantime
Labels
frontend

Comments

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Dec 21, 2022 •
edited
Loading

Need help from others:

  • No marfan syndrome as example query. I need some new example nodes to put in there.
  • Single tagline right underneath logo. "Phenotype connection"? https://docs.google.com/document/d/1i7zwT3C0WzHuXqlao7Pw9c_NqwxyAPvcqiN6arTOlRE/edit
  • The three big "tiles" on the homepage under "what is monarch" need to be changed. Maybe replace with several bullet points specific to each stakeholder: informaticians, patients, clinical geneticists, researchers. Include "Model organism network"?
  • Add note above search box: "Explore our knowledge on this website"?

Vince's tasks:

  • "Back to results" link on node page, if coming from a search.
  • Add search box to toolbar with search icon. Use auto complete query only. Submit to go to (detailed) node search results page. If not showing any rich details (like category), de-dupe autocomplete results, since it is just submitting a text string to the regular detailed node search.
  • In node search results, people are confused by the icons. Maybe add a legend at bottom, or add icons in category dropdown select.
  • In dropdown components, distinguish between hover and keyboard select states. Apologies to Moni, I think she mentioned this and I misunderstood what she was saying and dismissed it. The user should be able to press enter to select (for accessibility), but only after selecting the option by arrow keys, not by hovering with mouse.
@putmantime putmantime self-assigned this Jan 13, 2023
@putmantime
Copy link

@vincerubinetti and @putmantime will go through this together soon.

@vincerubinetti vincerubinetti transferred this issue from monarch-initiative/monarch-ui-new Apr 12, 2023
@vincerubinetti
Copy link
Contributor Author

@putmantime can you assign someone to the first bullet list.

@vincerubinetti vincerubinetti mentioned this issue Aug 24, 2023
Merged
vincerubinetti added a commit that referenced this issue Aug 24, 2023
@vincerubinetti
Header search, re-add breadcrumbs, other small features (#288)
ea1ddd4 
Closes #266 
Closes #227 
Closes #77 
Closes #80

Summary of changes (for reviewers, going commit by commit is better for
this PR):

- rework 404 redirect
- add "BETA" to prod banner
- update category icons
- change css data attr selectors to class selectors
- show taxon info in node badge for genes
- in node badge, remove link option. instead, show link unless already
on page being linked to (current node).
- rework and reinsert breadcrumbs, but only hook up to hierarchy
- refactor predicate badge
- dont automatically change case of labels in select components, do that
from parent using it
- in multi select component, solo-select first option clicked
- add icon support to multi select component
- in select components, fix hover then enter press bug
- tweak table component styling, save expanded state to local storage
- fix tab component keyboard wrapping behavior
- add search box to header and change styles to accommodate
- tweak homepage nexus visualization
- on testbed, show all custom icons
- change tab search higher-order-component to accommodate search box in
header
- re-add breadcrumbs section
- add "back to search" button at top of node page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincerubinetti vincerubinetti

@putmantime putmantime

Labels
frontend
Projects
Tim's Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Header search, re-add breadcrumbs, other small features monarch-initiative/monarch-app
2 participants
@vincerubinetti @putmantime