Skip to content
This repository has been archived by the owner on Feb 19, 2023. It is now read-only.

DO NOT MERGE: ODK #22

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

DO NOT MERGE: ODK #22

wants to merge 53 commits into from

Conversation

matentzn
Copy link
Member

@matentzn matentzn commented Aug 1, 2019

ODK config is managed here

@matentzn matentzn requested a review from cmungall August 1, 2019 07:08
@matentzn
Copy link
Member Author

I could use some help with the Definition of Done here; even if it is just a brain dump. @cmungall @kshefchek
By that I mean: in the absence of the possibility of reviewing the entire diff; what needs to happen so we can merge this in? As a first pass I would say this:

  • Make list of and review MAJOR differences (i.e. 1000K UBERON subs missing or similar)
  • Make list of terms in old monarch-ontology not anymore in new
  • Make list of terms without labels
  • Ontology consistent

What else would you say? Is this enough to merge in, and then fix the almost certainly upcoming issues as we go along, or are there other things we need to look out for?

@cmungall
Copy link
Member

Whatever we do, it needs to be timed with whatever the monarch data release cycle is, so there are no surprises.

Semantics-based QC is hard due to knock-on effect of inference. We need to get some kind of system in place, I started writing something.

For now, can you summarize in a few sentences what you think the expected changes are based on the changes you made.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants