Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter button itself shouldn't be multiselect #2

Closed
1 of 3 tasks
nathandunn opened this issue Sep 26, 2018 · 2 comments
Closed
1 of 3 tasks

Filter button itself shouldn't be multiselect #2

nathandunn opened this issue Sep 26, 2018 · 2 comments
Assignees

Comments

@nathandunn
Copy link
Contributor

nathandunn commented Sep 26, 2018

  • Button should be labeled "All" when nothing selected or the name of the filter
  • button shouldn't allow multi-selection
  • drop-down filter shouldn't overlap results if at all possible

From #1 (comment)

@pnrobinson
Copy link
Member

@monicacecilia Is this issue still relevant? I do not understand what the action item is? Please close or provide details about what needs to be done.

@nathandunn
Copy link
Contributor Author

I think that it was an awkward filter to have this me a multi-select (think of the way Amazon does this) versus a single select:

image

I wouldn't bother for a 1.0 release, but it would be better to convert it to a single select at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants