-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix all the searches #1
Comments
The 'text search' feature is probably most easily implemented by porting the VueJS code in monarch-app over into a VueJS SFC. The components are:
|
And if you DO port the VueJS search, the paging should work right. Right now, every time you say "Show me more results", it just makes the page longer. That's sort of bogus and unwieldy. Might have been a side-effect of a SOLR limitation on paging? But hopefully BL has better paging support. |
Home page search should look like this: The specific items in order of importance are:
Thanks! |
@jmcmurry I need to be able to edit the issues so I can update the check boxes. Also, its better to let me edit the todo-list based on your comments. |
@nathandunn np for you to edit both the list and the check boxes; you should have perms to do so now. |
Just an FYI, the longer term vision of autocomplete rendering is described here with rationale. |
I may break this into multiple issues, but this is everything I have for now.
adapted from: #1 (comment)
Filter button itself shouldn't be multiselectmoved to Filter button itself shouldn't be multiselect #2~~Wire up the "search in all results" to give you what you get here https://alpha.monarchinitiative.org/search/marfan ~~ moved to create text search option #5
autopopulate the first item of autocomplete results as "search < foo > in all results"; it is appropriate that this item be preselected so that if the user presses 'enter' they get to the search results page with facets.(ND: I think this is a bad idea UI-wise and is more complex to implement than what I put in there (by default if nothing is selected, do the full search). This follows the UI convections of both AMZN and GOOGLE )===
The text was updated successfully, but these errors were encountered: