Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich publication representation #420

Open
jmcmurry opened this issue Jun 2, 2021 · 9 comments
Open

Enrich publication representation #420

jmcmurry opened this issue Jun 2, 2021 · 9 comments
Assignees

Comments

@jmcmurry
Copy link
Member

jmcmurry commented Jun 2, 2021

On the publications tab of each node page

  • Add First Author last name, Title (First x words ok), Journal (abbreviations OK), Year add pub details to pub card, and various css fixes #438
  • Add to the publications node page a hyperlinked list of mentioned diseases, phenotypes, etc. However, these should not be in a table as they might be construed as biological data instead of just context.
@pnrobinson
Copy link
Member

Sorry @jmcmurry I did not see this until I posted my issues, which partially overlap.

In general I would love to see less use of tabs and to put more information on one page.

@vincerubinetti
Copy link
Contributor

@kshefchek or anyone, is there rate limiting on the Entrez API.

I was trying to use the existing getPublication function in src/api/Entrez.js to get the details for each publication, but I'm getting CORS errors after the first request. If I space out the requests by ~500ms, they don't throw any errors. Any idea why this would be happening?

It looks like the NCBI endpoints we're querying have the option to accept a list of pubmed ids instead of just one, so I'm currently trying to rewrite getPublication so that it can accept an array of ids as well.

@kshefchek
Copy link
Contributor

they rate limit 3 requests/second without an api key, so sending a batch all at once is the way to go

@vincerubinetti
Copy link
Contributor

The first bullet point of this issue is addressed by #438

As for the second bullet point, how can we implement this. Is this list of mentions something that is already populated in the data somewhere? Can any of the biolink services provide this information somehow?

@kshefchek
Copy link
Contributor

for mentions, I think the closest we have is the data that is shown in each table on the publications page, but we should limit these to direct=true since there are also some inferences included otherwise with varying accuracy.

@vincerubinetti
Copy link
Contributor

Are you referring to this table:

image

If I have the terminology right, this is not the publication page, but the publication card on a non-publication node page. Also what do you mean by direct=true. Is that referring to when relation is source?

The only mention of direct I see in the code is related to phenotypes.

If this is indeed the table you're talking about, then it sounds like Julie's second bullet point is already implemented, it's just that she wants it to not be in tabular format because it could be construed as having biological meaning (perhaps this is also what you meant by "otherwise with varying accuracy")?

I need more clarity here. There's not enough verbosity in this issue for me (as a non-biologist who hasn't been here for the development lifetime of this app) to actually act on and resolve.

@kshefchek
Copy link
Contributor

we probably need @jmcmurry to confirm, but I think the second bullet point is for pages like these: https://monarchinitiative.org/publication/PMID:25614286, instead of tabs with tables with a few rows each, listing the ids in those tables on the overview card. direct=true refers to the biolink calls that happen to generate the tables on the publication page. It might be easier to ignore that for now and just figure out exactly what this should look like.

@jmcmurry
Copy link
Member Author

Was hoping for something more like this. Remove "neighbors" if possible as this isn't relevant for pubs. Hide the left panels as this is more data-ey. We just want to show (and hyperlink) the recognized entities.

image

@vincerubinetti
Copy link
Contributor

Bullet point 1 is closed by #438.

Since bullet point 2 is larger in scope, I'll do that in a separate pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Monarch UI v1.1
  
Awaiting triage
Development

No branches or pull requests

4 participants