-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pub details to pub card, and various css fixes #438
Conversation
✔️ Deploy Preview for monarch-ui ready! 🔨 Explore the source changes: 1ea554a 🔍 Inspect the deploy log: https://app.netlify.com/sites/monarch-ui/deploys/61081e825229ba00088127be 😎 Browse the preview: https://deploy-preview-438--monarch-ui.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@kshefchek and/or @jmcmurry can you take a look at what I have so far (which addresses the first bullet point of #420). I didn't add publisher because the table was already getting too crowded, so I thought title, author, and year would be enough identifying information at a glance. And you can always click on the publication to get more authors and details. |
perhaps instead of showing the PMID id we replace that with the title? I think that's how it was originally intended but we ended up using PMIDs as a fall back (and as you can see we haven't stored many titles in our db) |
This is implemented now. |
This looks amazing, thanks! My only feedback is that it would be great if possible to include the journal. To make room, we can jettison date specifics (Year is fine). |
Incorporated. I used the field |
@jmcmurry Can you review the update and approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks
related: #420
getPublication
to accept list of ids instead of a single id, and refactorsstill in progress