-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to text annotator #422
Enhancements to text annotator #422
Conversation
fixes errors in parsing when the returned matching term contains a comma, e.g., "dilution, pigmentary"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, tested it out and it's working great!
@@ -204,6 +230,7 @@ export default { | |||
methods: { | |||
back() { | |||
this.annotatedText = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still used? If not please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "annotatedText" variable contains all the data returned from SciGraph and is the "source of truth" so to speak. There are some issues with SciGraph not returning appropriate categories or no category at all (see #415 for example), so I created two variables: one to store the output from the API ("annotatedText") and one to store a modified version that strips out terms with blank categories and/or assigns a usable category for display in the UI ("annotTextCleaned"). The complete list of unmodified annotations from SciGraph is what is exported, so yes, "annotatedText" is still used. Both variables would need to be reset if the user goes back to the previous step to modify the text they want to annotate.
Addresses #209. Removes unlinked recognized terms; adds ability to download all results; adds info popup text to 'Download' and 'Analyze Phenotypes' buttons.