Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Adding ability to load individuals from in-memory data as well as off-disk. #71
Conversation
julesjacobsen
added some commits
Mar 14, 2017
julesjacobsen
requested review from cmungall, jnguyenx, and drseb
Mar 15, 2017
|
One question on naming. Should |
|
individualAssociations would be more precise
We need the label loading to get human-friendly results returned. Some
clients will have their own way of doing a lookup, others will rely on
the service
```
addAxiom(df.getOWLAnnotationAssertionAxiom(df.getRDFSLabel(),
ind.getIRI(), df.getOWLLiteral(label))
```
|
|
OK so these methods need to change their signatures too. Here 'data' means 'individualAssociations'. Does this make sense for public Loader loadDataFromOntology(String path) {
sourceDataBuilder.dataOntology(path);
return this;
}
public Loader loadDataFromOntologies(String... paths) {
sourceDataBuilder.dataOntologies(paths);
return this;
}
public Loader loadDataFromOntologies(Collection<String> paths) {
sourceDataBuilder.dataOntologies(paths);
return this;
}
public Loader loadDataFromTsv(String path) {
sourceDataBuilder.dataTsv(path);
return this;
}
public Loader loadDataFromTsv(String... paths) {
sourceDataBuilder.dataTsv(paths);
return this;
}
public Loader loadDataFromTsv(Collection<String> paths) {
sourceDataBuilder.dataTsv(paths);
return this;
}
public Loader loadDataFromMap(Map<String, ? extends Collection<String>> data) {
sourceDataBuilder.data(data);
return this;
} |
cmungall
approved these changes
Mar 20, 2017
I haven't had time to fully explore but broadly this looks good
| @@ -18,12 +20,37 @@ public void testItAll() { | ||
| curies.put("MP", "http://purl.obolibrary.org/obo/MP_"); | ||
| curies.put("NCBITaxon", "http://purl.obolibrary.org/obo/NCBITaxon_"); | ||
| + Map<String, List<String>> individuals = new LinkedHashMap<>(); |
drseb
Mar 20, 2017
Owner
We should now have a thought about how to add additional information to an annotation. E.g. a weight or something.
Is it already possible to add negation?
|
I think it is good. Thanks. Can't test this right now. |
|
OK, cheers for looking. @drseb I think this should make it possible to do what you need. If not, open another ticket. |
julesjacobsen
closed this
Mar 20, 2017
julesjacobsen
reopened this
Mar 20, 2017
julesjacobsen
merged commit 933184c
into
monarch-initiative:master
Mar 20, 2017
1 check was pending
|
Thanks. I will test ASAP |
julesjacobsen commentedMar 15, 2017
Fix for @drseb in issue #57 enabling individuals data to be loaded into the knowledgebase from a
Maprather than off disk.