-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to load individuals from in-memory data as well as off-disk. #71
Adding ability to load individuals from in-memory data as well as off-disk. #71
Conversation
…, added toString.
…ledgebase to make API more self-explanatory.
…s to the Ontology via the OwlKnowledgeBase and the OntologyDataSource.
One question on naming. Should |
individualAssociations would be more precise
We need the label loading to get human-friendly results returned. Some
clients will have their own way of doing a lookup, others will rely on
the service
```
addAxiom(df.getOWLAnnotationAssertionAxiom(df.getRDFSLabel(),
ind.getIRI(), df.getOWLLiteral(label))
```
|
OK so these methods need to change their signatures too. Here 'data' means 'individualAssociations'. Does this make sense for public Loader loadDataFromOntology(String path) {
sourceDataBuilder.dataOntology(path);
return this;
}
public Loader loadDataFromOntologies(String... paths) {
sourceDataBuilder.dataOntologies(paths);
return this;
}
public Loader loadDataFromOntologies(Collection<String> paths) {
sourceDataBuilder.dataOntologies(paths);
return this;
}
public Loader loadDataFromTsv(String path) {
sourceDataBuilder.dataTsv(path);
return this;
}
public Loader loadDataFromTsv(String... paths) {
sourceDataBuilder.dataTsv(paths);
return this;
}
public Loader loadDataFromTsv(Collection<String> paths) {
sourceDataBuilder.dataTsv(paths);
return this;
}
public Loader loadDataFromMap(Map<String, ? extends Collection<String>> data) {
sourceDataBuilder.data(data);
return this;
} |
…ciations' in context of the Ontology/OntologySourceData/OwlKnowledgebase in order to be more specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had time to fully explore but broadly this looks good
@@ -18,12 +20,37 @@ public void testItAll() { | |||
curies.put("MP", "http://purl.obolibrary.org/obo/MP_"); | |||
curies.put("NCBITaxon", "http://purl.obolibrary.org/obo/NCBITaxon_"); | |||
|
|||
Map<String, List<String>> individuals = new LinkedHashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should now have a thought about how to add additional information to an annotation. E.g. a weight or something.
Is it already possible to add negation?
I think it is good. Thanks. Can't test this right now. |
OK, cheers for looking. @drseb I think this should make it possible to do what you need. If not, open another ticket. |
Thanks. I will test ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fix for @drseb in issue #57 enabling individuals data to be loaded into the knowledgebase from a
Map
rather than off disk.