Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding ability to load individuals from in-memory data as well as off-disk. #71

Merged
merged 5 commits into from Mar 20, 2017

Conversation

Projects
None yet
4 participants
Contributor

julesjacobsen commented Mar 15, 2017

Fix for @drseb in issue #57 enabling individuals data to be loaded into the knowledgebase from a Map rather than off disk.

@julesjacobsen julesjacobsen requested review from cmungall, jnguyenx, and drseb Mar 15, 2017

Contributor

julesjacobsen commented Mar 16, 2017

One question on naming. Should .loadDataFromMap(data) really be loadIndividuals? We still have no way of importing labels and presumably this requires different OWLAPI calls.

Owner

cmungall commented Mar 16, 2017

Contributor

julesjacobsen commented Mar 16, 2017

OK so these methods need to change their signatures too. Here 'data' means 'individualAssociations'. Does this make sense for loadDataFromOntology be changed to loadIndividualAssociationsFromOntology given these are actually just being merged? Should there just be a single set of loadOntology or loadInstancedOntology?

         public Loader loadDataFromOntology(String path) {
            sourceDataBuilder.dataOntology(path);
            return this;
        }

        public Loader loadDataFromOntologies(String... paths) {
            sourceDataBuilder.dataOntologies(paths);
            return this;
        }

        public Loader loadDataFromOntologies(Collection<String> paths) {
            sourceDataBuilder.dataOntologies(paths);
            return this;
        }

        public Loader loadDataFromTsv(String path) {
            sourceDataBuilder.dataTsv(path);
            return this;
        }

        public Loader loadDataFromTsv(String... paths) {
            sourceDataBuilder.dataTsv(paths);
            return this;
        }

        public Loader loadDataFromTsv(Collection<String> paths) {
            sourceDataBuilder.dataTsv(paths);
            return this;
        }

        public Loader loadDataFromMap(Map<String, ? extends Collection<String>> data) {
            sourceDataBuilder.data(data);
            return this;
       }
@julesjacobsen julesjacobsen Issue #57 changed uses of 'data' to 'individualAssociations' in conte…
…xt of the Ontology/OntologySourceData/OwlKnowledgebase in order to be more specific.
75bf89f
Contributor

julesjacobsen commented Mar 20, 2017

@cmungall / @jnguyenx can you comment on this further or merge this please. We can add the labels in another PR.

@cmungall

I haven't had time to fully explore but broadly this looks good

@@ -18,12 +20,37 @@ public void testItAll() {
curies.put("MP", "http://purl.obolibrary.org/obo/MP_");
curies.put("NCBITaxon", "http://purl.obolibrary.org/obo/NCBITaxon_");
+ Map<String, List<String>> individuals = new LinkedHashMap<>();
@drseb

drseb Mar 20, 2017

Owner

We should now have a thought about how to add additional information to an annotation. E.g. a weight or something.

Is it already possible to add negation?

Owner

drseb commented Mar 20, 2017

I think it is good. Thanks. Can't test this right now.

@drseb

drseb approved these changes Mar 20, 2017

Contributor

julesjacobsen commented Mar 20, 2017

OK, cheers for looking. @drseb I think this should make it possible to do what you need. If not, open another ticket.

@julesjacobsen julesjacobsen reopened this Mar 20, 2017

@julesjacobsen julesjacobsen merged commit 933184c into monarch-initiative:master Mar 20, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Owner

drseb commented Mar 20, 2017

Thanks. I will test ASAP

@jnguyenx

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment