Change path passed to disk_usage to be the file's parent directory #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haotongwang
requested review from
hallgchris,
khanguslee,
nix-chu and
emilytrau
emilytrau
suggested changes
Aug 4, 2020
nix-chu
suggested changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
backend.py,disk_usage(docs) is used to find the space left on the disk. Currently,__file__(the path to the executing file) is passed to it but this is only introduced in python 3.8 while the install instructions state that python 3.7.7 is to be used.Using
__file__in aNotADirectoryerror for me, whereas using the parent directory of__file__works as expected.Steps to Test
Install
raspicamRun
python overlay_new.py