-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner Component Typescript Migration #894
Comments
Hi @orrgottlieb, I would like to pick this up. I would be following the patterns used in the .tsx and .ts files already present in the project. |
Hi @suvnshr go for it! |
Hey @orrgottlieb I'm wanted you to review some changes before I commit them, coz I think I will have to make changes to Button.tsx and Icon.tsx: The close button snippet used in Button.jsx, cannot be used as is in Button.tsx because of a lot of restrictions of types:
So my question is shall I go ahead and add the required types in Button.tsx and Icon.tsx?I have ran all tests after making the above changes, and there were no failures. PS: If I am not supposed to make the above changes then let me know how I can render that Button without triggering the above violations, thanks! |
Hi @suvnshr thank you for the comments
As this migration process is a work in progress you can fix types according to new needs |
Ok sure. Will do the changes. Thanks! |
TypeScript here we come!
We are migrating to typescript, we are doing so component by component
We would love some help in converting some of our component to typescript - we've created a README
https://github.com/mondaycom/monday-ui-react-core/blob/master/TYPESCRIPT_MIGRATION.md
in this PR we expect you to convert the following files
Good luck!
The text was updated successfully, but these errors were encountered: