refactor(Banner): Migrated from JS to TS #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Migrated `Banner` to Typescript + Migrated `BannerConstants` to Typescipt + Migrated `banner.jest` to Typescipt + Replaced type `string` with type `ReactNode` of `children` prop in `Button` + Added type `number` to `size` prop of `iconSubComponentProps` + Created a new type for `onClick` prop of `iconSubComponentProps`
|
@orrgottlieb Here you go ❇️ Let me know if any changes are required. |
orrgottlieb
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
@suvnshr Awesome job!
I'm approving as the comments are small, please tag me once you do these changes
again, really awesome job!
+ `onClose` can also be triggered due to a KeyboardEvent.
|
@orrgottlieb I've made the required changes. |
orrgottlieb
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Thanks for an awesome job! and thank you @suvnshr for the contribution, we will merge and add the appropriate label
P.S
If you have any feedback on the package.- i would love it if you can write it to me
thank you
3 tasks
|
Thanks for the kind words @orrgottlieb overall I liked the design system. Wanted to ask you whether the coz I didn't see its doc in the storybook Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bannerto TypescriptBannerConstantsto Typescriptbanner.jestto Typescriptstringwith typeReactNodeofchildrenprop inButtonnumbertosizeprop oficonSubComponentPropsonClickprop oficonSubComponentPropsRelated issue: #894
Basic
npm run plop) to create a new component.PropTypes.Style
NewComponent.modules.scssfile inside of theNewComponentfolder.Storybook
/src/NewComponent/__stories__/NewComponent.stories.jsfile.Tests