Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AvatarGroup): add disabled state #2126

Merged
merged 7 commits into from
May 29, 2024
Merged

feat(AvatarGroup): add disabled state #2126

merged 7 commits into from
May 29, 2024

Conversation

talkor
Copy link
Contributor

@talkor talkor commented May 19, 2024

@talkor talkor requested a review from a team as a code owner May 19, 2024 07:00
YossiSaadi
YossiSaadi reviewed May 27, 2024
View reviewed changes
packages/core/src/components/Avatar/__stories__/assets/person1.png Outdated Show resolved Hide resolved
packages/core/src/components/Avatar/__stories__/assets/person2.png Outdated Show resolved Hide resolved
packages/core/src/components/Avatar/__stories__/assets/person3.png Outdated Show resolved Hide resolved
packages/core/src/components/Avatar/__stories__/assets/person4.png Outdated Show resolved Hide resolved
packages/core/src/components/AvatarGroup/AvatarGroupCounter.module.scss Show resolved Hide resolved
packages/core/src/components/AvatarGroup/AvatarGroupCounter.tsx Show resolved Hide resolved
packages/core/src/components/AvatarGroup/__stories__/assets/person2.png Outdated Show resolved Hide resolved
packages/core/src/components/AvatarGroup/__stories__/assets/person1.png Outdated Show resolved Hide resolved
packages/core/src/components/AvatarGroup/__stories__/assets/person4.png Outdated Show resolved Hide resolved
packages/core/src/components/AvatarGroup/__stories__/assets/person3.png Outdated Show resolved Hide resolved
@talkor talkor requested a review from YossiSaadi May 27, 2024 08:41
YossiSaadi
YossiSaadi approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, did you made those images with GenAI? 🤯

@talkor
Copy link
Contributor Author

talkor commented May 29, 2024

BTW, did you made those images with GenAI? 🤯

LOL no, they were in figma but I saw it was taken from Unsplash so I guess they are real people

@talkor talkor merged commit cf65f6b into master May 29, 2024
10 checks passed
@talkor talkor deleted the feat/AvatarGroup/add-disabled-state branch May 29, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talkor @YossiSaadi