Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development extras check for setup.py files #16

Merged
merged 14 commits into from
Mar 10, 2022
Merged

Conversation

mondeja
Copy link
Owner

@mondeja mondeja commented Mar 10, 2022

No description provided.

@mondeja mondeja added the enhancement New feature or request label Mar 10, 2022
@mondeja mondeja marked this pull request as draft March 10, 2022 11:13
@mondeja mondeja changed the title Implement development extras check for setup.py files Add development extras check for setup.py files Mar 10, 2022
@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 1965685217

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 52 of 55 (94.55%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 84.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
hooks/dev_extras_required.py 52 55 94.55%
Totals Coverage Status
Change from base Build 1652393682: 1.8%
Covered Lines: 310
Relevant Lines: 365

💛 - Coveralls

@mondeja mondeja marked this pull request as ready for review March 10, 2022 20:44
@mondeja mondeja merged commit c1d1761 into master Mar 10, 2022
@mondeja mondeja deleted the dev-extras-setup-py branch March 10, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants