Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Quick Facts French Translation #5

Merged
merged 1 commit into from Aug 31, 2018
Merged

Conversation

el00ruobuob
Copy link
Contributor

All is in the tittle.

While translating, i found two outdated facts (as of 7/26/2018) :

  • MRL has published 6 reports, not 5
  • Ledger is supported since CLI 0.12.2 and GUI 0.12.3

This version contains those correction.
However, i'll let you correct English and Spanish @lh1008.

@lh1008 lh1008 merged commit 4c79458 into monero-ecosystem:master Aug 31, 2018
@lh1008
Copy link
Contributor

lh1008 commented Aug 31, 2018

Awesome! I haven't made the changes in the original files, I will be doing them soon.

@lh1008
Copy link
Contributor

lh1008 commented Aug 31, 2018

I saw two fr links from the getmonero.org are not displayed yet.

  • Chaine de blocks

https://getmonero.org/fr/resources/moneropedia/blockchain.html-technology/404

  • fongible

https://getmonero.org/resources/fr/moneropedia/fungibility.html

Do you know if this links are already being worked, or they have issues un the monero-site?

@el00ruobuob
Copy link
Contributor Author

Those two looks like copy and paste typos. I will correct them quickly tonight or tomorrow. Sorry about that.

@lh1008
Copy link
Contributor

lh1008 commented Aug 31, 2018

Sure it's ok :)

@lh1008
Copy link
Contributor

lh1008 commented Sep 3, 2018

@el00ruobuob I checked the https://lab.getmonero.org/ and the sixth report has not been added to the website. Thank you for the notice. Let me see if I can also work it out.

@el00ruobuob
Copy link
Contributor Author

el00ruobuob commented Sep 3, 2018

@lh1008, it was added in monero-project/monero-site#817 but the site has not been rebuilt since. It's a matter of weeks now with the upcoming 0.13

@lh1008
Copy link
Contributor

lh1008 commented Sep 3, 2018

Ok, thank you for the response. I noticed a strange tag when building the website from jekyll that I would like to make a notice about. Will be doing a new issue on monero-site also. :) What is 0.13?

@el00ruobuob
Copy link
Contributor Author

A strange tag? Which? 0.13 is upcoming network upgrade of 10/18

@lh1008
Copy link
Contributor

lh1008 commented Sep 3, 2018

Yes take a look.

en_blog

en_press

I haven't changed anything. I noticed it last week, when I was looking at the Press-kit section to add the quickfacts pdf. I then went to all the links inside the website and found that the "Recent News/ All Blog Post" also has the same @lang_tag_en, and it displays in all languages too (es,fr,it,pl, and ar). I also notified @rehrar about it.

@el00ruobuob
Copy link
Contributor Author

It should be removed by moneropedia ruby script

@el00ruobuob
Copy link
Contributor Author

Did you git clone in a new folder? Otherwise it might be using the old script.

@el00ruobuob
Copy link
Contributor Author

Oh I have the same behavior here. Some pages are not going through the script while I added the tag to them. Will fix this, but an issue should be appropriate to track them all.

@lh1008
Copy link
Contributor

lh1008 commented Sep 3, 2018

Ok, I will be opening the issue tracking all of them. I was not sure how to fix it, but I was trying to troubleshoot it, with no success.

Did you git clone in a new folder?

yes :)

I'm working on adding the quickfact pdf to the press-kit section. Already added some lines. I have been taking a bit because I'm still learning how to update the website. If I need help maybe I will be bothering you through chat :P.

@el00ruobuob
Copy link
Contributor Author

Feels free to! I'm looking at the tag but don't understand why the files are not going through the moneropedia ruby script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants