Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code stype #84

Closed
vv12131415 opened this issue Feb 11, 2019 · 3 comments · Fixed by #143
Closed

Use code stype #84

vv12131415 opened this issue Feb 11, 2019 · 3 comments · Fixed by #143

Comments

@vv12131415
Copy link
Contributor

Thank you for the library. It's awesome because it helps me to work with monero more easily.

But during looking at the code, I've found that code does not look very pretty (at least to me).
What I want is to encourage use of code styles. The best one that I see at the moment is https://github.com/doctrine/coding-standard ( with we can configure)

@serhack
Copy link
Member

serhack commented Feb 12, 2019

Thank you, I can confirm a a partial rewritten is necessary. The problem is I do not have a lot of time for this since I'm studying.

@vv12131415
Copy link
Contributor Author

Thank you, I can confirm a a partial rewritten is necessary. The problem is I do not have a lot of time for this since I'm studying.

@serhack I can make PRs if you want

@recanman
Copy link
Contributor

@vladyslavstartsev (if you're still active), do you have recommendations on a code style? I've never used one with PHP.
PRs would be helpful.

serhack added a commit that referenced this issue Oct 19, 2023
Add Php CodeSniffer and PHPStan Fix #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants