Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deserialize_block_header to Cryptonote.php and delete Serialize.php #142

Merged
merged 2 commits into from Oct 19, 2023
Merged

Move deserialize_block_header to Cryptonote.php and delete Serialize.php #142

merged 2 commits into from Oct 19, 2023

Conversation

recanman
Copy link
Contributor

I'm not sure why there is a separate Serialize.php for a singular function (that is related to Cryptonote), so I moved it to Cryptonote.php.

serhack
serhack approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@serhack serhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what we were thinking about, probably I wanted to add more methods to Serialize.php (like deserialize_tx, deserialize_block_content). Thanks, looks good to me.

@recanman recanman mentioned this pull request Sep 29, 2023
Open
@serhack serhack merged commit 0d2fa4e into monero-integrations:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhack serhack serhack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@recanman @serhack