draft: Final touches (closes #147, #135, #133, #132, #124, #111, #100, #92, #82, #81, #57, #54)

[recanman]

This pull request contains the final changes needed for the package migration.
Package name will be changed to monero-integrations/monero-crypto (namespace MoneroIntegrations\MoneroCrypto)

This will also bump the minimum PHP version to 8.1.
A fork of refring's work. This will be called monero-integrations/monero-rpc (namespace MoneroIntegrations\MoneroRpc).

Tasks left:

• Finish refactoring the other classes and add unit tests for them
  • Varint
  • Base58
  • Mnemonic
  • Subaddress
  • Ed25519
  • Cryptonote
• Create a workflow for publishing on Packagist
• Create a new repository in monero-integrations for the MoneroRpc package
• Write some documentation/redo the README

Most of my work is usually offline/on my local git server and I may not push to this PR's branch frequently.

I've spent some time with refring's code and tested it (it is very good). Merging it is just a matter of creating a new repository (I will CC serhack at the appropriate time)

[recanman]

An extremely important task is to have tests for these cryptographic operations (to make sure results are consistent of course). If anyone seeing this is willing to give an expected input/output for each function in Cryptonote.php while I'm refactoring, that would be really great (if it isn't done, I'll do it myself. Just in case anyone else wants to speed up the migration process).

[recanman]

Rewriting it with sodium does not seem feasible at the moment as certain functions are not too well-documented. I've decided to add types, tests, and clean up the code for ed25519 and Cryptonote.
The scalarmult function in the ed25519 class is recursive and incredibly slow (15+ seconds). I'll fix that as well.

Here's my progress on Cryptonote.php:

• keccak_256
• gen_new_hex_seed
• sc_reduce
• hash_to_scalar
• derive_viewKey
• gen_private_keys
• pk_from_sk
• gen_key_derivation
• derivation_to_scalar
• stealth_payment_id
• txpub_from_extra
• derive_public_key
• is_output_mine
• encode_address
• verify_checksum
• decode_address
• integrated_addr_from_keys
• address_from_seed
• generate_subaddr_secret_key
• generate_subaddress_spend_public_key
• generate_subaddr_view_public_key
• generate_subaddress
• deserialize_block_header

[recanman]

Just added the publishing workflow. I'm about 80% done with the rest of the refactoring, but yet to polish it up and push it here.
@serhack, could you create a new repository under this organization? My name suggestion would be monerophp-rpc.

[recanman]

Ed25519 (public methods in reference implementation:

• H
• expmod
• inv
• xrecover
• edwards
• scalarmult
• encodeint
• encodepoint
• bit
• Hint
• publickey
• signature
• isoncurve
• decodeint
• decodepoint
• checkvalid

[serhack]

@serhack, could you create a new repository under this organization? My name suggestion would be monerophp-rpc.

Sorry, I've missed a point, why shouldn't there be only one repo with all PHP related library?

[recanman]

I don't think Composer can manage a monorepo with multiple packages.
Two packages: one for the cryptography operations, and one for the wallet/daemon RPC client

[recanman]

@serhack, any updates?

[serhack]

Tomorrow I'll create the second repository :)

[serhack]

@recanman I created the new repository