Documentation, formatting changes, and better parameter-handling on set_bans() #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change all $this_method's_parameters variables to, simply, $params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There aren't any major changes here. The only change in the code is formatting the
set_bansparameters like @gnock's latest contribution... The big addition here is documentation (which is still under development for the ed25519, SHA3, and cryptonote libraries, but exists in basic form as of this pull request.) I've gone through and made easy-to-follow documentation for all our files that will also be added to getmonero.org once its formatting is changed to match that setup. Docs live in/docsand are linked to from README.md, with nice markdown formatting.I should open three separate pull request, but that seems like a lot for what isn't actually a changes.