Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary check_spend_proof fix #74

Closed
wants to merge 2 commits into from
Closed

temporary check_spend_proof fix #74

wants to merge 2 commits into from

Conversation

itssteven
Copy link
Contributor 

$txid = 'd77b32a3dfb3a1f549100e4831f225f4b4be7ccb854982c14dd7048f624cb2f1';
$txid2 = '9c1e5ba94e50cd51d809ed013b6cc593a484b8991fcbaacf2edf4af69f6d3212';

$wat = $walletRPC->get_spend_proof( $txid );
echo 'get_spend_proof: ', PHP_EOL;
print_r( $wat );

$wat2 = $walletRPC->check_spend_proof( $txid2, $wat['signature'] );
echo 'check_spend_proof: ', PHP_EOL;
print_r( $wat2 );

This will return good=>false now, rather than throwing an exception because of 'incorrect signature size'

@itssteven
temporary check_spend_proof fix
9b1a211 
$txid = 'd77b32a3dfb3a1f549100e4831f225f4b4be7ccb854982c14dd7048f624cb2f1';
$txid2 = '9c1e5ba94e50cd51d809ed013b6cc593a484b8991fcbaacf2edf4af69f6d3212';

$wat = $walletRPC->get_spend_proof( $txid );
echo 'get_spend_proof: ', PHP_EOL;
print_r( $wat );

$wat2 = $walletRPC->check_spend_proof( $txid2, $wat['signature'] );
echo 'check_spend_proof: ', PHP_EOL;
print_r( $wat2 );

...

This will return good=>false now, rather than throwing an exception because of 'incorrect signature size'
@itssteven
Update jsonRPCClient.php
28df5d6
@serhack
Copy link
Member

serhack commented May 6, 2018

Hello,
thanks for submitting a pull request.

I can not accept this fixing because the library CAN'T return a non-rpc array. It should return the answer from RPC response.

@itssteven
Copy link
Contributor Author

I agree. I'll try to get it fixed at the root.

@itssteven itssteven closed this May 6, 2018
@itssteven itssteven mentioned this pull request May 6, 2018
Closed
itssteven added a commit to itssteven/monero that referenced this pull request May 6, 2018
@itssteven
check_spend_proof
eb9f3a3 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
@itssteven itssteven mentioned this pull request May 6, 2018
Merged
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 17, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
03fc09b 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
263a775 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
fc5cc1e 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
3790ace 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
5f7b408 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
13801d0 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
b9f4af5 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
d924be8 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
bfb99ce 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
c1917fd 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
b0febe2 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
stoffu pushed a commit to stoffu/monero that referenced this pull request Jun 19, 2018
@itssteven @stoffu
check_spend_proof /monero#3762
939e609 
My intention is to mitigate monero-project#3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: monero-integrations/monerophp#72 & my temp fix: monero-integrations/monerophp#74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itssteven @serhack