Switch to subaddresses

[serhack]

This issue aims to track the progresses about switching to subaddresses, instead of integrated address.

[itssteven]

Hi, I've done this via the RPC. I'm not sure how to push/pull/whatever my changes as I never use git. Here's a preview on the wownero version: itssteven@1a10c4d

[serhack]

I'm seeing this.. I have a little improvement to do. (why not adding a checkbox "Use subaddress instead of integrated address" ?) Anyway, good job!

[itssteven]

I think it might confuse the user, and don't we want to depreciate payment IDs/integrated addresses?

An improvement: The order page has the fields "payment id" and "integrated address" and instead should only have "subaddress". Currently both fields fill with the subaddress because I set both $payment_id and $integrated_address to = $subaddress to avoid making too many changes to the code. I only know how to generate a subaddress via the RPC, I don't know how to generate a subaddress with math, so the payment_id stuff is necessary for the address+viewkey explorer setup. If this (https://www.reddit.com/r/Monero/comments/ac0xwn/javascript_subaddress_generator_released/ed83roe/) gets converted to PHP I'll make these changes and switch it entirely over to subaddresses.

[serhack]

We want to deprecate the integrated address for sure! But I think we should not switch from integrated address to subaddress in one release. Or should we? I was thinking @sgp had a roadmap for this..

[ghost]

Afaik @SamsungGalaxyPlayer has proposed completely transitioning to sub-addresses by March 2020

[SamsungGalaxyPlayer]

fwiw this roadmap has not been finalized, and Wownero can probably afford to be a little more ambitious.

[itssteven]

#79

Be sure to give it a test run first. I have, but maybe I missed something.

[serhack]

I'll review it asap!

[ghost]

thanks @itssteven

[itssteven]

https://raw.githubusercontent.com/monero-integrations/monerophp/master/src/subaddress.php

On my x220 it takes 45 seconds to get 1 subaddress (http://paste.debian.net/plainh/e10a6b56). Assuming that's not just me doing something wrong, how's best to go forward from here?

There's Knacc's javascript version of subaddress.php which could perhaps be implemented into the likes of https://xmr.llcoins.net/ for the users to use their own cpu and time to generate a bunch of subaddresses to import into the website for later use.