Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Reseed fails on Debian Sid (unstable) #210

Closed
1 task done
anonimal opened this issue Jun 19, 2016 · 16 comments
Closed
1 task done

Reseed fails on Debian Sid (unstable) #210

anonimal opened this issue Jun 19, 2016 · 16 comments

Comments

@anonimal
Copy link
Collaborator

anonimal commented Jun 19, 2016

By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

Place an X inside the bracket to confirm

  • I confirm.

First reported by @EinMByte, this appears to be specific to Debian Jessie (all tests pass and Reseed is fully functional on Arch and Ubuntu Wily/Trusty).

Output (omitting passing tests):

kovri/src/tests/unit_tests/core/Reseed.cpp(254): error in "GoodSU3": check su3.SU3Impl() failed
*** 1 failure detected in test suite "Master Test Suite"

Build info:

-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is GNU 4.9.2
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Performing Test CXX14_SUPPORTED
-- Performing Test CXX14_SUPPORTED - Success
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Boost version: 1.55.0
-- Found the following Boost libraries:
-- chrono
-- log
-- program_options
-- date_time
-- thread
-- system
-- filesystem
-- regex
-- Found Crypto++: /usr/include, /usr/lib/libcryptopp.so
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libssl.so;/usr/lib/x86_64-linux-gnu/libcrypto.so (found version "1.0.1t")
-- Found MiniUPnP headers: /usr/include/miniupnpc
-- --------------------------------------- [103/359]
-- Build type : Debug
-- Compiler vendor : GNU
-- Compiler version : 4.9.2
-- Compiler path : /usr/bin/c++
-- Install prefix: : /usr/local
-- Kovri data directory: /home/kovri/.kovri
-- Options:
-- BENCHMARKS : ON
-- BINARY : ON
-- CRYPTOPP : ON
-- DOXYGEN : OFF
-- HARDENING : OFF
-- LIBRARY : ON
-- OPTIMIZATION : OFF
-- STATIC BUILD : OFF
-- SUPERCOP : ON
-- TESTS : ON
-- UPnP : OFF

-- Boost version: 1.55.0
-- Found the following Boost libraries:
-- unit_test_framework
-- chrono
-- program_options
-- date_time
-- thread
-- system
-- filesystem
-- regex
-- Configuring done
-- Generating done
-- Build files have been written to: /home/kovri/build

A very crude hypothesis (until I look into this further): the issue may be related to compiler version and how we initialize SU3FixtureImpl's byte argument (our suggested gcc minimum requirement is 5.3.0).

Note: there is currently a Jessie bug with CMake and OpenSSL as reported here (opened less than 2 weeks ago) which prevents CMake from working. A simple work-around is provided in the link.

@EinMByte
Copy link
Contributor

More complete log of ./kovri-tests:

$ ./kovri-tests
...
default:default     DBG     SU3: preparation successful
default:default     DBG     SU3: verifying stream...
default:default     ERR     SU3: signature failed
default:default     ERR     SU3: verification failed
kovri-tests: asn.cpp:415: virtual CryptoPP::BERGeneralDecoder::~BERGeneralDecoder(): Assertion `0' failed.
unknown location(0): fatal error in "GoodX509": signal: SIGABRT (application abort requested)
/kovri/src/tests/unit_tests/core/crypto/util/X509.cpp(97): last checkpoint
default:default     ERR     X509: certificate is not PEM
default:default     ERR     X509: failed to process certificate
default:default     ERR     X509: certificate is not PEM
default:default     ERR     X509: failed to process certificate
kovri-tests: asn.cpp:415: virtual CryptoPP::BERGeneralDecoder::~BERGeneralDecoder(): Assertion `0' failed.
unknown location(0): fatal error in "BadContent": signal: SIGABRT (application abort requested)
/kovri/src/tests/unit_tests/core/crypto/util/X509.cpp(119): last checkpoint
default:default     DBG     ZIP: preparing local file...
default:default     DBG     ZIP: successfully prepared file
default:default     DBG     ZIP: decompressing local file...
default:default     DBG     ZIP: processing file routerInfo-1mAmAGGkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
default:default     DBG     ZIP: file uses compression method 'deflate'
default:default     DBG     ZIP: successfully processed file
default:default     DBG     ZIP: successfully unzipped stream
default:default     ERR     ZIP: missing central directory header
default:default     DBG     ZIP: preparing local file...
default:default     ERR     ZIP: archive data descriptor not found
default:default     DBG     ZIP: preparing local file...
default:default     DBG     ZIP: successfully prepared file
default:default     DBG     ZIP: decompressing local file...
default:default     DBG     ZIP: processing file routerInfo-1mAmAGGkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
default:default     ERR     ZIP: file uses an unsupported compression method
default:default     DBG     ZIP: preparing local file...
default:default     DBG     ZIP: successfully prepared file
default:default     DBG     ZIP: decompressing local file...
default:default     DBG     ZIP: processing file routerInfo-1mAmAGGkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
default:default     DBG     ZIP: file uses compression method 'deflate'
default:default     ERR     ZIP: CRC-32 Failed
default:default     DBG     ZIP: preparing local file...
default:default     DBG     ZIP: successfully prepared file
default:default     DBG     ZIP: decompressing local file...
default:default     DBG     ZIP: processing file routerInfo-1mAmAGGkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 577 bytes
default:default     DBG     ZIP: file uses compression method 'deflate'
default:default     ERR     DeflateDecompressorImpl: Put() caught exception 'Inflator: unexpected end of compressed block'
default:default     ERR     ZIP: CRC-32 Failed
default:default     DBG     ZIP: preparing local file...
default:default     DBG     ZIP: successfully prepared file
default:default     DBG     ZIP: decompressing local file...
default:default     DBG     ZIP: processing file routerInfo-1mAmAGGkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
default:default     DBG     ZIP: file uses compression method 'deflate'
default:default     ERR     ZIP: actual uncompressed size 671 exceeds 577 from header
default:default     DBG     ZIP: preparing local file...
default:default     ERR     ZIP: archived filename length not appropriate: 65

*** 2 failures detected in test suite "Master Test Suite"

@EinMByte EinMByte self-assigned this Jun 20, 2016
@EinMByte
Copy link
Contributor

I've labeled this as critical because it also causes a crash on startup if new keys have to be generated.

@EinMByte
Copy link
Contributor

It seems to be a Crypto++ bug: the BERGeneralDecoder destructor had an assert 0; line.
This was fixed in this commit.

@EinMByte
Copy link
Contributor

EinMByte commented Jun 20, 2016

I fail to see why the debian repositories only contain a -dev package for crypto++, which has assertions enabled.
Current workaround is to use a custom crypto++ installation with the latest version from github, or with -DNDEBUG.

@anonimal
Copy link
Collaborator Author

System (freshly updated):

$ uname -a
Linux 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2 (2016-04-08) x86_64 GNU/Linux

Kovri master b078bd5 built and tested against:

$ dpkg -l libcrypto++-dev | tail -n1
ii  libcrypto++-dev 5.6.1-6+deb8u2 amd64        General purpose cryptographic library - C++ development

On fresh startup, produces no crash (though Reseed will fail as expected):

$ rm -fr ~/.kovri/ && cd ~/kovri/build/ && rm -fr CMake* && cmake ../ && time make -j4 && ./kovri
2016:06:20|21:11:27.076408|NFO   Crypto: checking for AES-NI...
2016:06:20|21:11:27.077762|NFO   Crypto: AES-NI is available!
2016:06:20|21:11:27.078891|NFO   The Kovri I2P Router Project
2016:06:20|21:11:27.079714|NFO   Version 0.1.0-pre-alpha
2016:06:20|21:11:27.082423|NFO   Daemon_Singleton: initializing
2016:06:20|21:11:27.129812|NFO   Daemon_Singleton: 1 I2P client tunnels created
2016:06:20|21:11:27.130255|NFO   Daemon_Singleton: 0 I2P server tunnels created
2016:06:20|21:11:27.130851|NFO   Daemon_Singleton: listening on port 9559
Not opening log file: 
2016:06:20|21:11:27.131380|NFO   Daemon_Singleton: starting NetDb
2016:06:20|21:11:27.133666|NFO   NetDb: 0 routers loaded
2016:06:20|21:11:27.134008|NFO   NetDb: 0 floodfills loaded
2016:06:20|21:11:27.134534|DBG   Reseed: processing certificates...
2016:06:20|21:11:27.135439|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/bugme_at_mail.i2p.crt"
2016:06:20|21:11:27.136144|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.136845|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.137325|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/matt_at_drollette.com.crt"
2016:06:20|21:11:27.137798|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.138214|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.138978|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/zmx_at_mail.i2p.crt"
2016:06:20|21:11:27.140246|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.140506|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.140981|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/meeh_at_mail.i2p.crt"
2016:06:20|21:11:27.141434|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.142063|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.142381|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/parg_at_mail.i2p.crt"
2016:06:20|21:11:27.143388|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.143992|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.144456|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/echelon_at_mail.i2p.crt"
2016:06:20|21:11:27.145255|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.145496|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.146169|DBG   Reseed: acquiring signing key from "/home/kovri/.kovri/certificates/su3/backup_at_mail.i2p.crt"
2016:06:20|21:11:27.146834|DBG   X509: successfully processed certificate
2016:06:20|21:11:27.147041|DBG   X509: successfully acquired signing key
2016:06:20|21:11:27.147570|NFO   Reseed: successfuly loaded 7 certificates
2016:06:20|21:11:27.148094|NFO   Reseed: fetching stream from https://reseed.i2p-projekt.de/i2pseeds.su3
2016:06:20|21:11:28.990907|NFO   HTTP: Connected to reseed.i2p-projekt.de:443
2016:06:20|21:11:29.478795|NFO   Reseed: fetch successful
2016:06:20|21:11:29.479425|DBG   SU3: preparing stream...
2016:06:20|21:11:29.479729|DBG   SU3: found reseed data
2016:06:20|21:11:29.485037|ERR   SU3: invalid signer ID
2016:06:20|21:11:29.485438|ERR   SU3: preparation failed
2016:06:20|21:11:29.485792|ERR   Reseed: SU3 implementation failed
2016:06:20|21:11:29.486378|ERR   NetDb: reseed failed
2016:06:20|21:11:29.486861|ERR   Daemon_Singleton: NetDb failed to start
2016:06:20|21:11:29.487501|NFO   Daemon_Singleton: stopping client
2016:06:20|21:11:29.488284|NFO   ClientContext: HTTP Proxy stopped
2016:06:20|21:11:29.489538|NFO   ClientContext: SOCKS Proxy stopped
2016:06:20|21:11:29.490551|NFO   ClientContext: I2P client tunnel on port 6669 stopped
2016:06:20|21:11:29.492416|NFO   Daemon_Singleton: stopping tunnels
2016:06:20|21:11:29.492756|NFO   Daemon_Singleton: stopping transports
2016:06:20|21:11:29.493005|NFO   Daemon_Singleton: stopping NetDb
2016:06:20|21:11:29.493239|NFO   Goodbye!

For tests, no fatal errors but still produces:

$ rm -fr ~/.kovri/ && cd ~/kovri/build/ && rm -fr CMake* && cmake -DWITH_TESTS=ON -DWITH_BENCHMARKS=ON ../ && time make -j4 && ./kovri-tests
2016:06:20|21:18:27.552543|NFO   Crypto: checking for AES-NI...
2016:06:20|21:18:27.553633|NFO   Crypto: AES-NI is available!
Running 69 test cases...
2016:06:20|21:18:27.555375|DBG   SU3: preparing stream...
2016:06:20|21:18:27.556038|DBG   SU3: found reseed data
2016:06:20|21:18:27.563889|ERR   SU3: invalid signer ID
2016:06:20|21:18:27.564341|ERR   SU3: preparation failed
/home/kovri/kovri/src/tests/unit_tests/core/Reseed.cpp(254): error in "GoodSU3": check su3.SU3Impl() failed
2016:06:20|21:18:27.565186|DBG   SU3: preparing stream...
2016:06:20|21:18:27.565727|ERR   SU3: invalid magic value
2016:06:20|21:18:27.566489|ERR   SU3: preparation failed
2016:06:20|21:18:27.567463|DBG   SU3: preparing stream...
2016:06:20|21:18:27.568053|ERR   SU3: signature type not supported
2016:06:20|21:18:27.568805|ERR   SU3: preparation failed
2016:06:20|21:18:27.569740|DBG   SU3: preparing stream...
2016:06:20|21:18:27.570122|ERR   SU3: invalid signature length
2016:06:20|21:18:27.570987|ERR   SU3: preparation failed
2016:06:20|21:18:27.571745|DBG   SU3: preparing stream...
2016:06:20|21:18:27.573251|ERR   SU3: version length too short
2016:06:20|21:18:27.573646|ERR   SU3: preparation failed
2016:06:20|21:18:27.574404|DBG   SU3: preparing stream...
2016:06:20|21:18:27.574808|ERR   SU3: invalid signer ID length
2016:06:20|21:18:27.575455|ERR   SU3: preparation failed
2016:06:20|21:18:27.576264|DBG   SU3: preparing stream...
2016:06:20|21:18:27.576719|ERR   SU3: invalid content length
2016:06:20|21:18:27.577400|ERR   SU3: preparation failed
2016:06:20|21:18:27.578276|DBG   SU3: preparing stream...
2016:06:20|21:18:27.578708|ERR   SU3: invalid file type 4
2016:06:20|21:18:27.579168|ERR   SU3: preparation failed
2016:06:20|21:18:27.580123|DBG   SU3: preparing stream...
2016:06:20|21:18:27.580539|ERR   SU3: invalid content type 5
2016:06:20|21:18:27.581075|ERR   SU3: preparation failed
2016:06:20|21:18:27.581894|DBG   SU3: preparing stream...
2016:06:20|21:18:27.582202|DBG   SU3: found reseed data
2016:06:20|21:18:27.587470|ERR   SU3: invalid signer ID
2016:06:20|21:18:27.588043|ERR   SU3: preparation failed
2016:06:20|21:18:27.588705|DBG   SU3: preparing stream...
2016:06:20|21:18:27.589020|DBG   SU3: found reseed data
2016:06:20|21:18:27.593545|ERR   SU3: invalid signer ID
2016:06:20|21:18:27.594005|ERR   SU3: preparation failed
2016:06:20|21:18:27.594588|DBG   SU3: preparing stream...
2016:06:20|21:18:27.594950|DBG   SU3: found reseed data
2016:06:20|21:18:27.598859|ERR   SU3: invalid signer ID
2016:06:20|21:18:27.599318|ERR   SU3: preparation failed
2016:06:20|21:18:27.601102|DBG   SU3: preparing stream...
2016:06:20|21:18:27.601471|DBG   SU3: found reseed data
2016:06:20|21:18:27.608514|ERR   SU3: invalid signer ID
2016:06:20|21:18:27.609110|ERR   SU3: preparation failed
2016:06:20|21:18:27.746200|DBG   X509: successfully processed certificate
2016:06:20|21:18:27.747022|DBG   X509: successfully acquired signing key
2016:06:20|21:18:27.747811|ERR   X509: certificate is not PEM
2016:06:20|21:18:27.748561|ERR   X509: failed to process certificate
2016:06:20|21:18:27.749279|ERR   X509: certificate is not PEM
2016:06:20|21:18:27.749893|ERR   X509: failed to process certificate
2016:06:20|21:18:27.750903|ERR   X509: PEM decoding exception 'BER decode error'
2016:06:20|21:18:27.751602|ERR   X509: failed to decode certificate
2016:06:20|21:18:27.752278|ERR   X509: failed to process certificate
2016:06:20|21:18:27.754314|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.754673|DBG   ZIP: successfully prepared file
2016:06:20|21:18:27.755148|DBG   ZIP: decompressing local file...
2016:06:20|21:18:27.755967|DBG   ZIP: processing file routerInfo-1mAmAGgkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
2016:06:20|21:18:27.756574|DBG   ZIP: file uses compression method 'deflate'
2016:06:20|21:18:27.757415|DBG   ZIP: successfully processed file
2016:06:20|21:18:27.757846|DBG   ZIP: successfully unzipped stream
2016:06:20|21:18:27.758535|ERR   ZIP: missing central directory header
2016:06:20|21:18:27.759084|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.759593|ERR   ZIP: archive data descriptor not found
2016:06:20|21:18:27.760304|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.760611|DBG   ZIP: successfully prepared file
2016:06:20|21:18:27.761361|DBG   ZIP: decompressing local file...
2016:06:20|21:18:27.761791|DBG   ZIP: processing file routerInfo-1mAmAGgkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
2016:06:20|21:18:27.762167|ERR   ZIP: file uses an unsupported compression method
2016:06:20|21:18:27.762771|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.763088|DBG   ZIP: successfully prepared file
2016:06:20|21:18:27.763447|DBG   ZIP: decompressing local file...
2016:06:20|21:18:27.764116|DBG   ZIP: processing file routerInfo-1mAmAGgkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
2016:06:20|21:18:27.764397|DBG   ZIP: file uses compression method 'deflate'
2016:06:20|21:18:27.764913|ERR   ZIP: CRC-32 Failed
2016:06:20|21:18:27.765538|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.765820|DBG   ZIP: successfully prepared file
2016:06:20|21:18:27.766239|DBG   ZIP: decompressing local file...
2016:06:20|21:18:27.766715|DBG   ZIP: processing file routerInfo-1mAmAGgkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 577 bytes
2016:06:20|21:18:27.766999|DBG   ZIP: file uses compression method 'deflate'
2016:06:20|21:18:27.767383|ERR   ZIP: CRC-32 Failed
2016:06:20|21:18:27.768146|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.768448|DBG   ZIP: successfully prepared file
2016:06:20|21:18:27.768844|DBG   ZIP: decompressing local file...
2016:06:20|21:18:27.769304|DBG   ZIP: processing file routerInfo-1mAmAGgkmTwdgiDQUMy7UUO9qxcVSssWZL3qbScQrIg=.dat 648 bytes
2016:06:20|21:18:27.769781|DBG   ZIP: file uses compression method 'deflate'
2016:06:20|21:18:27.770272|ERR   ZIP: actual uncompressed size 671 exceeds 577 from header
2016:06:20|21:18:27.771066|DBG   ZIP: preparing local file...
2016:06:20|21:18:27.771463|ERR   ZIP: archived filename length not appropriate: 65

*** 1 failure detected in test suite "Master Test Suite"

😕

@anonimal anonimal changed the title Reseed unit-test fails on Debian Jessie Reseed fails on Debian Jessie Jun 20, 2016
@EinMByte
Copy link
Contributor

Make sure to build without -DNDEBUG.

@anonimal
Copy link
Collaborator Author

Bingo.

latest version from github, or with -DNDEBUG

I thought "or" was optional - it should be "and" (if building before weidai11/cryptopp@bb32763) 😊

Building against weidai11/cryptopp@bb32763 and master does fix the dtor/SIGABRT issue but the original issue still stands (failed GoodSU3 and failure to reseed). Can you reproduce that portion of the issue?

@EinMByte
Copy link
Contributor

@anonimal All tests passing on my fork, maybe it's due to some recent changes?

@anonimal anonimal changed the title Reseed fails on Debian Jessie Reseed fails on Debian Jessie / Fedora 21 Jul 7, 2016
@anonimal
Copy link
Collaborator Author

anonimal commented Jul 7, 2016

As reported in #monero-dev by moneromooo, this also effects Fedora 21.

Both the binary and tests produce the results seen in #210 (comment).

@anonimal anonimal changed the title Reseed fails on Debian Jessie / Fedora 21 Reseed fails on Debian Jessie Jul 7, 2016
@anonimal
Copy link
Collaborator Author

anonimal commented Jul 7, 2016

#220 fixed Fedora. Now we need to test against Debian.

@anonimal
Copy link
Collaborator Author

anonimal commented Jul 7, 2016

#220 also fixes a fresh, vanilla Debian Jessie (I still can't reproduce those assertions with libcrypto++-dev 5.6.1-6+deb8u2).

@anonimal
Copy link
Collaborator Author

anonimal commented Jul 9, 2016

@EinMByte I'm able to reproduce the assertions on Debian unstable - but this ticket was specifically for Jessie. What sources are you pulling from for apt?

@EinMByte
Copy link
Contributor

EinMByte commented Jul 9, 2016

@anonimal
ii libcrypto++-dev 5.6.3-6 amd64 General purpose cryptographic library - C++ development

@anonimal
Copy link
Collaborator Author

anonimal commented Jul 9, 2016

Indeed. Shall we rename ticket to Reseed fails on Debian Sid (unstable) or similar?

@EinMByte
Copy link
Contributor

EinMByte commented Jul 9, 2016

@anonimal Yes, indeed.

@EinMByte EinMByte changed the title Reseed fails on Debian Jessie Reseed fails on Debian Sid (unstable) Jul 9, 2016
@anonimal
Copy link
Collaborator Author

2016-07-22     &anonimal       EinMByte: Hi. I'm wondering if we should add a crypto++ submodule in order to resolve #210.
2016-07-22     &anonimal       Testing if system is relevent ubuntu would be trivial; either in cmake or the makefile.
2016-07-22     &anonimal       EinMByte: on 2nd thought, I *really* would like to do that because of that compression issue I had to fix a while back.
2016-07-22     &anonimal       They've fixed it and its sitting in their repo.
2016-07-22     &anonimal       And who knows when they will have their next release.
2016-07-22     &anonimal       Of course there is the question of stability, but we can work off a specific commit and see how she runs.
2016-07-22      *      anonimal would rather work with them than against them (e.g., crypto_refactor)

Also, there is the question of security - but we are still in pre-alpha. And by the time cryptopp has another release... we may be in beta.

I'm not too attached to the idea but I like the idea of becoming more involved with cryptopp through kovri. Also, they're getting a lot of work done lately.

I'm open to thoughts.

Referencing #141.

@anonimal anonimal self-assigned this Jul 27, 2016
anonimal added a commit that referenced this issue Jul 27, 2016
562f9af Build: remove cryptopp dependency in travis and docs (anonimal)
ff23ded Build: fix cmake cryptopp link failure for 2.8.12 (anonimal)
ad73ea2 Build: cleanup cryptopp recipe in cmake (anonimal)
87e02b8 Build: fix wrong path in cmake for cryptopp libs (anonimal)
609a4a3 Build: implement cryptopp submodule. Fixes #210 (anonimal)
EinMByte added a commit to EinMByte/kovri that referenced this issue Aug 26, 2016
f936ffe Docs: remove EC2 build instructions (anonimal)
44daa5a Docs: consolidate + improve Quality Assurance guide (anonimal)
1462240 Docs: implement Quality Assurance guide. Refs monero-project#58 (anonimal)
719b7e8 Build: temporarily disable running tests after build (anonimal)
3a41c64 Docs: update Debian and Ubuntu build instructions (anonimal)
683a95a Docs: cleanup + update readme and building docs (anonimal)
9a8b88e Build: remove CXXFLAGS from Travis CI. Refs monero-project#316 (anonimal)
74f80fd Build: add CXXFLAGS for clang/cryptopp to Makefile (anonimal)
134791c Config: refactor command-line handler + update config file (anonimal)
79db048 Config: update and document kovri config file (anonimal)
f97cb1f Config/Daemon: clarify service option + refactor/remove deprecations (anonimal)
c7e54e6 Config: consolidate options + groupings. Refs monero-project#214 (anonimal)
87febb7 Log: remove deprecations marked TODO. Refs monero-project#214 (anonimal)
85415fe Log: implement options log-to-console/log-to-file + improve file logging (anonimal)
3ab8c07 Log: implement file logging. References monero-project#214 (anonimal)
f77fa78 Log: remove unneeded null_deleter check + redundant headers (anonimal)
48872a2 Build: add tests-optimized-hardening Makefile target (anonimal)
9542007 Build: update Makefile and build docs. Fixes monero-project#310 (anonimal)
703a268 Build: update OSX dependencies for Travis CI (anonimal)
263f881 Build: fix missed header guards + guard comments for monero-project#303 (anonimal)
1bb160c Build: add removal of doxygen output to make clean (anonimal)
418fa08 Configure OS X build on Travis-CI (rakhimov)
5a1de2c Reseed: add new server reseed.atomike.ninja (anonimal)
2d699b9 Doxygen: remove input filter + fix input & CMake (anonimal)
04a062a Style: rename common files to common idiom names (anonimal)
30d169d Style: move network_database -> net_db. Refs monero-project#280 (anonimal)
deba858 Build: update header guards. Fixes monero-project#303 (anonimal)
41f2237 Build: fix filename that broke tests build (anonimal)
ed52f05 Build: fix headers + cmake missed in 9c3dfba (anonimal)
ea3c1ea Initialize several unitialized members (monero-project#263). (EinMByte)
9c3dfba snake_case (guzzi_jones)
c77510f Style: remove file guidelines from guide. Refs monero-project#280 (anonimal)
da2ac61 Tests: adjust CMake for .cpp -> .cc from 2ade4a8 (anonimal)
57c8e80 rename files with snake case (guzzi_jones)
455349c Build: reinstate FreeBSD build. Resolves monero-project#176 (anonimal)
5f5b4a6 AddressBook: add custom hosts.txt file to package (anonimal)
388bf40 HTTP: implement SNI + update reseed. Fixes monero-project#129 (anonimal)
95c1ad5 Build: add CMake Boost min req + s/SEND_/FATAL_/g (anonimal)
2b8af8e Build: add compiler version requirements to CMake (anonimal)
9530329 Docs: trivial cleanup of style guide (anonimal)
90c9ed8 Docs: update minimum requirements + instructions (anonimal)
b50d936 Update dead link. (Patrick Alexander)
5286d91 Configure clang with gcc 4.9 on Travis-CI (rakhimov)
3e0577a Build: add windows msys2/mingw-w64 to build docs (anonimal)
611aa8c Build: fix compilation on mingw-w64. Refs monero-project#36 (anonimal)
749a04e mingw doesn't like c_str here (luigi1111)
9cb9b6e Build: update cryptopp submodule. Refs monero-project#36 (anonimal)
f075dea Build: remove clang from Travis CI. Refs monero-project#277 monero-project#278 (anonimal)
d0a5462 Build: fix clang build on Travis CI. Fixes monero-project#277 (anonimal)
7b5578d Docs: clarify Trusty 14.04 build instructions (anonimal)
fecabd2 Build: add boost status message in cmake (anonimal)
e3bd1f6 Build: uppercase Kovri resource dir for OSX/Win (anonimal)
f95a8ea Build: reduce build time + Makefile cleanup/fix (anonimal)
caa8ac2 Build: remove after_success from Travis CI (anonimal)
c8ead36 Build: run tests after successful make tests build (anonimal)
e8f615d License: revert copyright errors introduced in 2ade4a8 (anonimal)
2ade4a8 Added instructions for Amazon EC2 instance adjusted license comment renamed all .cpp files remove mv.sh fixed CMakeLists.txt files with new .cc removed t.txt fixed comments.  appended // to original comments missed util files (guzzi_jones)
7551d23 Docs: update .clang-format + update style guide (anonimal)
44e64e8 Travis-CI: comment clang build for reasons in monero-project#227 (anonimal)
cd4bd6a Docs: remove redundant export line for OSX (anonimal)
3d1ff55 Build: update clang/cryptopp instructions + Travis (anonimal)
08b51dc Travis-CI: fix clang version typo + gcc version (anonimal)
287ba83 Build: attempt multi-compiler in Travis CI (anonimal)
e8b1a3a Docs: bring back clang support in building doc (anonimal)
cc7aa70 Makefile: add flags for cryptopp clang support (anonimal)
90a90aa CMake: replace -std=c++14 with -std=c++1y for clang (anonimal)
41f7e40 Crypto: remove compression patch for cryptopp (anonimal)
562f9af Build: remove cryptopp dependency in travis and docs (anonimal)
ff23ded Build: fix cmake cryptopp link failure for 2.8.12 (anonimal)
ad73ea2 Build: cleanup cryptopp recipe in cmake (anonimal)
87e02b8 Build: fix wrong path in cmake for cryptopp libs (anonimal)
609a4a3 Build: implement cryptopp submodule. Fixes monero-project#210 (anonimal)
8167d44 Docs: add acknowledgements, move to doc directory (anonimal)
d696b33 Docs: clarify pull-request in contributing guide (anonimal)
5f11427 Docs: update pull-request template (anonimal)
814d8c9 Docs: update to reflect drop of branch development (anonimal)
4900040 Travis CI: remove on_success/on_failure (anonimal)
7ca81e9 Config: add reseed to cli help options. (anonimal)
fc4a796 Travis-CI: add full path for tests/benchmarks (anonimal)
d7d96f9 Travis-CI: move tests/benchmarks to script: (anonimal)
b6f38df Build: run tests and benchmarks on Travis CI (anonimal)
15f05e7 Build: update/cleanup Travis CI (anonimal)
691075f Makefile: add disable-options / add missing PHONY (anonimal)
88177fa Build: add/refactor targets in Makefile (anonimal)
038547b Build: fix shell warning in Makefile + refactor. (anonimal)
a07ec90 HTTP: rewrite URI parser. Fixes monero-project#257 (anonimal)
e33a368 Build: add commented YAML for travis-ci/travis-ci#5427 (anonimal)
f7c6786 Build: remove Coverity from Travis-CI. Closes monero-project#209 (anonimal)
ed9c8a8 Build: experiment with cov-configure in Travis-CI (anonimal)
dfccdc0 Docs: first-draft update of FAQ. Resolves monero-project#255. (anonimal)
7aa893e Docs: update boost 1.58 min req + add instructions (anonimal)
8d8d811 Build: add libboost-test1.58* to travis-ci. Refs monero-project#254. (anonimal)
d1130b3 Build: add -y to add-apt-repository in travis-ci. (anonimal)
8a7341f Build: fix typo in before_install in travis-ci. (anonimal)
8427401 Build: add boost 1.58 to travis-ci. Refs monero-project#254. (anonimal)
b916307 Build: add PHONY 'dependencies' to Makefile. (anonimal)
0d82989 Build: implement cpp-netlib (submodule/cmake/make/docs) (anonimal)
98a852b Build: add make install-resources to Travis-CI. (anonimal)
a96ac2b Docs: update build instructions for make install-resources (anonimal)
37c1cfd Build: fix Windows APPDATA path in Makefile. Refs monero-project#45. (anonimal)
8ea8276 Build: implement make install-resources. Fixes monero-project#45. (anonimal)
e70bd97 Build: fix shell'ism issue with travis. Refs monero-project#250. (anonimal)
db40f73 Build: fix travis error from timeout. Refs monero-project#249. (anonimal)
d531a5d Docs: add Clang to build instructions. Refs monero-project#242. (anonimal)
b3745b7 Build: allow passing CC/CXX from Makefile to CMake. (anonimal)
ba0385a Build: simplify build process. Resolves monero-project#242. (anonimal)
6675ec8 Docs: add contact info to README. Refs monero-project#241. (anonimal)
993a966 Docs: update and clarify style guide. Refs monero-project#245. (anonimal)
43621de Style: Clarify deviations from the GCSG (rakhimov)
b6c4d76 Fix StringStream::Seekg signature (rakhimov)
0527b14 Coverity: Remove unnecessary certificate fetch (rakhimov)
8230e46 Fix compilation with Clang 3.8 (rakhimov)
b219398 Add ClangFormat config for Google C++ Style (rakhimov)
527826e Docs: cleanup quickstart in README.md (anonimal)
bb6dfd7 Docs: add license status-badge to README.md (anonimal)
99e3bb9 Docs: add branch instructions to pull-request template. (anonimal)
31da8f0 Docs: update pull-request template's license caveat. (anonimal)
91a8ecc Docs: change links to cpplint project (rakhimov)
34c45cc Docs: fix trivial numbering in contributing guide. (anonimal)
eea4075 Crypto: use constant-time comparison in ed25519. (anonimal)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants