Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Crypto: minor fixes/refactor of AES-NI runtime check #388

Merged
merged 1 commit into from
Oct 2, 2016

Conversation

anonimal
Copy link
Collaborator

@anonimal anonimal commented Oct 2, 2016

By submitting this pull-request, I confirm the following:

  • I have read and understood the Contributing Guide.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

Place an X inside the bracket (or click the box in preview) to confirm

  • I confirm.

Successfully tested on both aesni enabled/disabled machines.

  • static const for global bool type
    • static is implied because this particular const type
      exists in namespace but static const appears 'const correct'
  • Log to debug channel, not info
  • Refactor if/else + type names for clarity
  • Add TODO for ARM support

References #285

- static const for global bool type
  - static is implied because this particular const type
    exists in namespace but static const appears 'const correct'
- Log to debug channel, not info
- Refactor if/else + type names for clarity
- Add TODO for ARM support

References monero-project#285
@anonimal anonimal merged commit fc224c9 into monero-project:master Oct 2, 2016
anonimal added a commit that referenced this pull request Oct 2, 2016
fc224c9 Crypto: minor fixes/refactor of AES-NI runtime check (anonimal)
@anonimal anonimal deleted the aesni-impl-285 branch October 6, 2016 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant