Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Review AES-NI implementation #285

Closed
1 task done
anonimal opened this issue Aug 1, 2016 · 3 comments
Closed
1 task done

Review AES-NI implementation #285

anonimal opened this issue Aug 1, 2016 · 3 comments
Assignees
@anonimal
Labels
crypto libcore maintenance medium

Comments

@anonimal
Copy link
Collaborator

anonimal commented Aug 1, 2016

By submitting this issue, I confirm the following:

  • I have read and understood the contributor guide.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

Place an X inside the bracket to confirm

  • I confirm.

Jeffrey Walton at cryptopp has made some helpful comments about our AES-NI implementation. We should review and fix where needed.
anonimal referenced this issue Aug 1, 2016
@anonimal
Crypto: implement runtime AES-NI. Resolves #73.
637b9a9
@anonimal
Copy link
Collaborator Author

Referencing weidai11/cryptopp#237 (comment) and related to avoid pitfalls when implementing ARM support for our runtime AES-NI.

@anonimal anonimal mentioned this issue Oct 2, 2016
Closed
1 task
anonimal added a commit to anonimal/kovri that referenced this issue Oct 2, 2016
@anonimal
Crypto: minor fixes/refactor of AES-NI runtime check
fc224c9 
- static const for global bool type
  - static is implied because this particular const type
    exists in namespace but static const appears 'const correct'
- Log to debug channel, not info
- Refactor if/else + type names for clarity
- Add TODO for ARM support

References monero-project#285
@anonimal anonimal mentioned this issue Oct 2, 2016
Merged
1 task
anonimal added a commit to anonimal/kovri that referenced this issue Nov 4, 2016
@anonimal
Build: fix ARMv7/8 builds. Fixes monero-project#384, refs monero-proj…
1256a6f 
…ect#285

- Fixes CMake for ARM, add compile-time patches for run-time AES-NI
- Preprocessor: also added MSVS macro for future MSVS testing
- Cleaned-up CMake / shared hardening flags with Clang
anonimal added a commit that referenced this issue Nov 7, 2016
@anonimal
Merge pull request #431
4f03407 
1256a6f Build: fix ARMv7/8 builds. Fixes #384, refs #285 (anonimal)
@anonimal anonimal mentioned this issue Aug 17, 2017
Merged
@anonimal
Copy link
Collaborator Author

Because of cryptopp's work in this area, we should eventually be able to drop all homebrewed AES-NI as well as forgo any ARM AES-NI: weidai11/cryptopp#429 (comment)

@anonimal anonimal added this to the 0.1.0-alpha milestone Jan 25, 2018
@anonimal anonimal self-assigned this Jan 25, 2018
@anonimal anonimal removed this from the 0.1.0-alpha milestone Jun 28, 2018
@anonimal
Copy link
Collaborator Author

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anonimal anonimal

Labels
crypto libcore maintenance medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anonimal