Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Build: fix ARMv7/8 builds. Fixes #384, refs #285 #431

Merged
merged 1 commit into from Nov 7, 2016

Conversation

anonimal
Copy link
Collaborator

@anonimal anonimal commented Nov 4, 2016

By submitting this pull-request, I confirm the following:

  • I have read and understood the Contributing Guide.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

Place an X inside the bracket (or click the box in preview) to confirm

  • I confirm.

  • Fixes CMake for ARM, add compile-time patches for run-time AES-NI
  • Preprocessor: also added MSVS macro for future MSVS testing
  • Cleaned-up CMake / shared hardening flags with Clang

…ect#285

- Fixes CMake for ARM, add compile-time patches for run-time AES-NI
- Preprocessor: also added MSVS macro for future MSVS testing
- Cleaned-up CMake / shared hardening flags with Clang
@anonimal
Copy link
Collaborator Author

anonimal commented Nov 4, 2016

Hi @danrmiller, the armv8 build needs miniupnpc.

Edit: also, the armv7 build was never triggered

@ghost
Copy link

ghost commented Nov 4, 2016

Have you seen how we detect arm and crypto options in monero'a CMakeLists.txt?

I know asking the compiler isn't ideal, but even the guys behind MBED find it hard to properly define the target architecture because AFAIK for some reason ARM keeps the internal options register protected

@anonimal
Copy link
Collaborator Author

anonimal commented Nov 4, 2016

@NanoAkron yes but I'm not sure how that's relevant now (crypto impl is currently handled by external libraries). What exactly do you mean? Lib-side compiler fine tuning can come later - after we get the builds running (or if someone else wants to get involved now).

@anonimal
Copy link
Collaborator Author

anonimal commented Nov 4, 2016

ARMv8 build is currently failing because of No space left on device. pigeons and host provider are currently working on a fix.

@anonimal anonimal merged commit 1256a6f into monero-project:master Nov 7, 2016
anonimal added a commit that referenced this pull request Nov 7, 2016
1256a6f Build: fix ARMv7/8 builds. Fixes #384, refs #285 (anonimal)
@anonimal anonimal deleted the fix-arm-build branch November 7, 2016 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant