Fixes #2275, transactionCommited txid list

txid list was empty when emitted
monero-project · Jul 8, 2019 · caeda05 · caeda05
1 parent c4b3fba
commit caeda05
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/libwalletqt/Wallet.cpp b/src/libwalletqt/Wallet.cpp
@@ -524,7 +524,8 @@ bool Wallet::submitTxFile(const QString &fileName) const
 void Wallet::commitTransactionAsync(PendingTransaction *t)
 {
     m_scheduler.run([this, t] {
-        emit transactionCommitted(t->commit(), t, t->txid());
+        auto txIdList = t->txid();
+        emit transactionCommitted(t->commit(), t, txIdList);
     });
 }
 

diff --git a/src/libwalletqt/Wallet.h b/src/libwalletqt/Wallet.h
@@ -351,7 +351,7 @@ class Wallet : public QObject
     void walletCreationHeightChanged();
     void deviceButtonRequest(quint64 buttonCode);
     void deviceButtonPressed();
-    void transactionCommitted(bool status, PendingTransaction *t, QStringList txid);
+    void transactionCommitted(bool status, PendingTransaction *t, const QStringList& txid);
     void heightRefreshed(quint64 walletHeight, quint64 daemonHeight, quint64 targetHeight) const;
 
     // emitted when transaction is created async