Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation and corrections of monero-core_es #1601

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

BlackLotus64
Copy link
Contributor

I've translated the missing lines of the gui file for the Spanish language, and also made a review of the already translated lines, all with Linguist QT. Everything seems to be OK but I haven't compiled the GUI since I read that there has been some problems with that.

Thanks to @lh1008 and @erciccione for the support, if you want to review the commit you're more than welcome, but I took my time checking everything so there won't be many mistakes :)

Copy link
Contributor

@lh1008 lh1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some missing spaces, but everything else is ok :) Great work!

@@ -1043,37 +1043,37 @@
<message>
<location filename="../pages/settings/SettingsInfo.qml" line="60"/>
<source>GUI version: </source>
<translation type="unfinished"></translation>
<translation>Versión de GUI:</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after ": "

GUI version:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linguist was marking a space in some lines so I added it, maybe this was one of them, like the others.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlackLotus64 Don't know what you mean with that, but linguist should tell you that the string is not ending in the same way of the source text. Please add the witespace here and in the other strings that @lh1008 pointed out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh OK now that I see, yes, the missing space is in my version. I saw some lines that lacked that space and corrected them, but it seems there were some others that didn't notice 😅

translations/monero-core_es.ts Show resolved Hide resolved
</message>
<message>
<location filename="../pages/settings/SettingsInfo.qml" line="89"/>
<source>Embedded Monero version: </source>
<translation type="unfinished"></translation>
<translation>Versión embedida de Monero:</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after ": "

</message>
<message>
<location filename="../pages/settings/SettingsInfo.qml" line="118"/>
<source>Wallet path: </source>
<translation type="unfinished"></translation>
<translation>Dirección de monedero:</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after ": "

</message>
<message>
<location filename="../pages/settings/SettingsInfo.qml" line="155"/>
<source>Wallet creation height: </source>
<translation type="unfinished"></translation>
<translation>Altura de creación del monedero:</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space after ": "

@BlackLotus64
Copy link
Contributor Author

Solved missing spaces

Copy link
Contributor

@lh1008 lh1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just two more comments. One missing space and one that a version has changed.

Thanks.

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1" language="es_ES">
<TS version="2.0" language="es_ES">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it changed to "2.0".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not a problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok :)

</message>
<message>
<location filename="../pages/settings/SettingsInfo.qml" line="236"/>
<source>Wallet log path: </source>
<translation type="unfinished"></translation>
<translation>Dirección de registro del monedero:</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing another space oups...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this and pushing again, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some other missing spaces with the Search tool looking at ':<', and changed just the ones that are missing. Left the other ones that are pair (the source text doesn't include a space) intact.

Copy link
Contributor

@lh1008 lh1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) 👍

@luigi1111 luigi1111 merged commit 851571c into monero-project:master Oct 9, 2018
luigi1111 added a commit that referenced this pull request Oct 9, 2018
851571c Translation update and added more missing spaces (BlackLotus64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants