-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation and corrections of monero-core_es #1601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some missing spaces, but everything else is ok :) Great work!
translations/monero-core_es.ts
Outdated
@@ -1043,37 +1043,37 @@ | |||
<message> | |||
<location filename="../pages/settings/SettingsInfo.qml" line="60"/> | |||
<source>GUI version: </source> | |||
<translation type="unfinished"></translation> | |||
<translation>Versión de GUI:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after ": "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linguist was marking a space in some lines so I added it, maybe this was one of them, like the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BlackLotus64 Don't know what you mean with that, but linguist should tell you that the string is not ending in the same way of the source text. Please add the witespace here and in the other strings that @lh1008 pointed out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh OK now that I see, yes, the missing space is in my version. I saw some lines that lacked that space and corrected them, but it seems there were some others that didn't notice 😅
translations/monero-core_es.ts
Outdated
</message> | ||
<message> | ||
<location filename="../pages/settings/SettingsInfo.qml" line="89"/> | ||
<source>Embedded Monero version: </source> | ||
<translation type="unfinished"></translation> | ||
<translation>Versión embedida de Monero:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after ": "
translations/monero-core_es.ts
Outdated
</message> | ||
<message> | ||
<location filename="../pages/settings/SettingsInfo.qml" line="118"/> | ||
<source>Wallet path: </source> | ||
<translation type="unfinished"></translation> | ||
<translation>Dirección de monedero:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after ": "
translations/monero-core_es.ts
Outdated
</message> | ||
<message> | ||
<location filename="../pages/settings/SettingsInfo.qml" line="155"/> | ||
<source>Wallet creation height: </source> | ||
<translation type="unfinished"></translation> | ||
<translation>Altura de creación del monedero:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after ": "
Solved missing spaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left just two more comments. One missing space and one that a version has changed.
Thanks.
@@ -1,6 +1,6 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<!DOCTYPE TS> | |||
<TS version="2.1" language="es_ES"> | |||
<TS version="2.0" language="es_ES"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it changed to "2.0".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's not a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok :)
translations/monero-core_es.ts
Outdated
</message> | ||
<message> | ||
<location filename="../pages/settings/SettingsInfo.qml" line="236"/> | ||
<source>Wallet log path: </source> | ||
<translation type="unfinished"></translation> | ||
<translation>Dirección de registro del monedero:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing another space oups...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing this and pushing again, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some other missing spaces with the Search tool looking at ':<', and changed just the ones that are missing. Left the other ones that are pair (the source text doesn't include a space) intact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) 👍
851571c Translation update and added more missing spaces (BlackLotus64)
I've translated the missing lines of the gui file for the Spanish language, and also made a review of the already translated lines, all with Linguist QT. Everything seems to be OK but I haven't compiled the GUI since I read that there has been some problems with that.
Thanks to @lh1008 and @erciccione for the support, if you want to review the commit you're more than welcome, but I took my time checking everything so there won't be many mistakes :)