Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mining: only update mining status when page is open #3889

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Mining: only update mining status when page is open #3889

merged 1 commit into from
Apr 25, 2022

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Apr 23, 2022

Due to a bug the GUI was constantly checking the mining status every two seconds, no matter if the mining page is open or not.

mj-xmr
mj-xmr approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@mj-xmr mj-xmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic makes sense, plus there's additional sanity check currentWallet !== undefined, but I would need a couple of hours today to validate if it actually works, unless you're absolutely sure of this.

@selsta
Copy link
Collaborator Author

selsta commented Apr 23, 2022

I did use some extra async logging to confirm that everything works fine.

@selsta selsta mentioned this pull request Apr 23, 2022
Closed
@luigi1111 luigi1111 merged commit 4de4e82 into monero-project:master Apr 25, 2022
@selsta selsta deleted the mining-status-check branch April 25, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj-xmr mj-xmr mj-xmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@selsta @mj-xmr @luigi1111