Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation of Moneropedia entries A - B #1224

Merged
merged 1 commit into from Nov 27, 2020

Conversation

Wobole
Copy link
Contributor

@Wobole Wobole commented Oct 4, 2020

The following entries were translated:

  • Account
  • Address
  • Airgap
  • Atomic Units
  • Block
  • Blockchain
  • Bootstrap Node
  • Bulletproofs

Note: The links to other Moneropedia entries (marked with an @) may not work in the preview since the terminology has to be updated with the German terms.

@netlify
Copy link

netlify bot commented Oct 4, 2020

Deploy preview for barolo-time-757cf9 ready!

Built without sensitive environment variables with commit b5942bb

https://deploy-preview-1224--barolo-time-757cf9.netlify.app

@erciccione
Copy link
Contributor

@Wobole This needs to be rebased.

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically OK. We need a translator to review these now. Same for the other PRs updating the German version of the Moneropedia

_i18n/de/resources/moneropedia/account.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/account.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/account.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/account.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/account.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/bulletproofs.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/bulletproofs.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/bulletproofs.md Outdated Show resolved Hide resolved
_i18n/de/resources/moneropedia/bulletproofs.md Outdated Show resolved Hide resolved
@erciccione
Copy link
Contributor

@stmax82 Thanks for your thorough review. It's very appreciated. Please make your future comments in English, so that also non-German speaker could be able to help with the review (for example for helping with context or technicalities) :)

Copy link
Contributor Author

@Wobole Wobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your extensive review, @stmax82 ! I adjusted the translations accordingly and/or commented on your suggestions.

@Wobole Wobole changed the title Translated 8 Moneropedia entries into German German translation of Moneropedia entries A - B Nov 13, 2020
The following entries were translated:
- Account
- Address
- Airgap
- Atomic Units
- Block
- Blockchain
- Bootstrap Node
- Bulletproofs
@luigi1111 luigi1111 merged commit 9b713ec into monero-project:master Nov 27, 2020
@Wobole Wobole deleted the first8 branch November 28, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants