Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'flag' to 'option' for consistency with CLI' #827

Closed
wants to merge 1 commit into from
Closed

Changed 'flag' to 'option' for consistency with CLI' #827

wants to merge 1 commit into from

Conversation

ordtrogen
Copy link
Contributor

See how the CLI talks about "options" instead of "flags".

image

@lh1008
Copy link
Contributor

lh1008 commented Aug 9, 2018

I have conflicts with the changing in this term. Even in the Microsoft Terminology Search says "Marca".

"Broadly, a marker of some type used by a computer in processing or interpreting information; a signal indicating the existence or status of a particular condition. Flags are used in such areas as communications, programming, and information processing."

We have opened a discussion in #799.

@ordtrogen
Copy link
Contributor Author

I hear you, but this PR isn't about the Spanish or any other translation so it's better discussed here.

"--daemon-address" is one of the "command line options" you can pass to monero-wallet-cli, that's why I claim "flag" should be "option" in the source. See:

https://en.wikipedia.org/wiki/Command-line_interface#Command-line_option

"option" in this sense can alse be called "flag" or "switch", like the wikipedia article says, but since the help text of monero-wallet-cli uses the term "option", the documentation should use "option" also.

@lh1008
Copy link
Contributor

lh1008 commented Aug 9, 2018

Wikipedia sometimes is a terrible source of information. Take a look at this wikipedia flag Spanish definition.

@BlackLotus64
Copy link
Contributor

I can just tell that flag is often used as bandera in spanish but it's more understandable as marcador (like option by the way). In the end it's just an option, flag is more like a technicality used in programmng and computer-related things.

In short, I think it can be changed, because even monerod uses Option, and like I said, flag in the end is just and option.

@lh1008
Copy link
Contributor

lh1008 commented Aug 9, 2018

You just said the word. Sometimes I forget the correct words. "Flag" Is "marcador", not "bandera". I vote for "marcador", not "opción". @BlackLotus64 what do you think about this?

@lh1008
Copy link
Contributor

lh1008 commented Aug 9, 2018

Let me give it one more try, because I think you aren't getting the context of what "flag", "marcador" in Spanish is. "Flag" is NOT "option".

The "options" = "opciones" in the monero-wallet-cli are:
--deamon-address arg
--deamon-host arg
--password arg...

You should use the "flag" = "marcador":
--deamon-address arg, when...
--deamon-address arg, when...
--password arg, when...

These are two different arguments even if "flag" means "option". One indicates what are your options, the other indicates what you should use(flag), or do the direct signal in a case of using the OPTION.

We have to differentiate them because in the context is used differently and mean differently, I gave you the wikipedia "flag" definition in spanish so you could read it in spanish because it clearly means something different. Not sure what @BlackLotus64 had in his mind when using the word "bandera" (that could also work), but he was in the context, and you aren't.

@lh1008
Copy link
Contributor

lh1008 commented Aug 9, 2018

I'll give you another example:

What is --deamon-address arg command different than an option?
A flag, why?
Because is used in information processing inside the CLI. So --deamon-address arg is an option inside the CLI that gives a signal inside the CLI, and how is called that signal? A flag, not an option. We can keep on arguing what it should be. Just take your time and read the text and ask yourself why was the word "flag" and not "option" used, it should mean something.

@BlackLotus64
Copy link
Contributor

I think it doesn't really matter, and yes @lh1008 the page talks more about internal structure of processors and states, but in the end it's the same as flags or options here, they just change values in the daemon and are indicators of that change.

We can ask for a programmer point of view for this, because in my university even professors said bandera in microcontrollers programming, even if we just knew that they were some kind of state/option/indicator.

But in my opinion, option is a bit more, um, let's say, for-all-people, when flag is more technical. In English it can also be marker.

@BlackLotus64
Copy link
Contributor

Maybe @el00ruobuob ? Because I'm almost new here I don't know a lot of people, but for now let's just stay with this PR, we can discuss later the translations to another language like Spanish, don't you think @lh1008 ?

@lh1008
Copy link
Contributor

lh1008 commented Aug 9, 2018

I just needed to make it clear. I'm always a detail person, this is not a personal engagement with anyone sorry guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants