Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary support for DragonFly BSD #1459

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

tuxillo
Copy link
Contributor

@tuxillo tuxillo commented Dec 15, 2016

  • It builds but no further testing has been done.

- It builds but no further testing has been done.
@hyc
Copy link
Collaborator

hyc commented Dec 15, 2016

Propagating platform-specific ifdefs like this is going to be unmaintainable and unsustainable. Should be using feature-specific ifdefs and configuring them all in a single place. (E.g., #ifdef HAVE_MALLOC_H instead of all those OS tests before including <malloc.h> )

@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 15, 2016

Well I just followed what was being done already.

@fluffypony
Copy link
Contributor

I agree with @hyc as a long-term solution, and it's something for somebody to refactor and fix later on. In the meantime this should be fine - I do wonder why FreeBSD and DragonFly don't present roughly the same environment? ie. could we do it as a more generic "BSD" check, or are there significant enough differences?

@tuxillo
Copy link
Contributor Author

tuxillo commented Dec 15, 2016

One would have to check the #ifdefs and see where they can be collapsed. There are certainly differences between the major BSD although I don't know if they'll apply to monero's use cases.

@fluffypony
Copy link
Contributor

Also @danrmiller, we'll need a build VM for DragonFly:)

@fluffypony
Copy link
Contributor

Tks - will chalk it up as something to investigate later...someday...when someone has time:)

Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit b00da61 into monero-project:master Dec 15, 2016
fluffypony added a commit that referenced this pull request Dec 15, 2016
b00da61 Preliminary support for DragonFly BSD (Antonio Huete Jimenez)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants