wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneromooo-monero
approved these changes
Jan 31, 2018
iDunk5400
reviewed
Feb 7, 2018
src/wallet/wallet_rpc_server.cpp
Outdated
| @@ -2425,7 +2425,7 @@ namespace tools | |||
| catch (const tools::error::not_enough_outs_to_mix& e) | |||
| { | |||
| er.code = WALLET_RPC_ERROR_CODE_NOT_ENOUGH_OUTS_TO_MIX; | |||
| er.message = e.what(); | |||
| er.message = e.what() + " Please use sweep_dust."; | |||
There was a problem hiding this comment.
I get a compilation error here:
... error: invalid operands of types ‘const char*’ and ‘const char [24]’ to binary ‘operator+’
er.message = e.what() + " Please use sweep_dust.";
I fixed it with:
er.message = e.what() + std::string(" Please use sweep_dust.");
stoffu
force-pushed
the
sweep-unmixable-msg
branch
from
a86b3bf
to
214d251
Compare
fluffypony
added a commit
that referenced
this pull request
Feb 16, 2018
214d251 wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown (stoffu)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by this post on StackExchange: https://monero.stackexchange.com/questions/7460/cant-transfer-monero-coins-strange-error-message