Add application version compatibility check. #5253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/device/device_ledger.cpp
Outdated
| if (minor < MINIMAL_MINOR_APP_VERSION) { | ||
| ASSERT_X(false, MINIMAL_VERSION_ERROR_MESSAGE); | ||
| } | ||
| #undef MINIMAL_VERSION |
There was a problem hiding this comment.
You probably want MINIMAL_VERSION_ERROR_MESSAGE here
src/device/device_ledger.cpp
Outdated
| } | ||
|
|
||
| #define MINIMAL_VERSION_ERROR_MESSAGE \ | ||
| "Unsuppotred device application version: "<<major<<"."<<minor<<"."<<micro<<"."\ |
src/device/device_ledger.cpp
Outdated
|
|
||
| #define MINIMAL_VERSION_ERROR_MESSAGE \ | ||
| "Unsuppotred device application version: "<<major<<"."<<minor<<"."<<micro<<"."\ | ||
| " At least " << MINIMAL_MAJOR_APP_VERSION<<"."<<MINIMAL_MINOR_APP_VERSION<<"."<<MINIMAL_MICRO_APP_VERSION << " is requiered." |
src/device/device_ledger.cpp
Outdated
| } | ||
| if (minor < MINIMAL_MINOR_APP_VERSION) { | ||
| ASSERT_X(false, MINIMAL_VERSION_ERROR_MESSAGE); | ||
| } |
There was a problem hiding this comment.
That seems wrong. It will fail once you get to 2.0.0.
Maybe, eg:
ASSERT_X(major*65536+minor*256+micro >= 0x010200, MINIMAL_VERSION_ERROR_MESSAGE);
(untested)
And you also get only one line with it :)
There was a problem hiding this comment.
you are right!.
I will take your approach with shift: (major<<24) | (minor<<16) | micro
src/device/device_ledger.cpp
Outdated
| this->exchange(); | ||
| this->exchange(); | ||
|
|
||
| ASSERT_X(this->length_recv>=3, "Communication error, less than tow three bytes received. Check your application version."); |
There was a problem hiding this comment.
major, minor, micro : three
There was a problem hiding this comment.
Yes, I mean the "tow" seems like it's extra unneeded word here.
There was a problem hiding this comment.
OMG yes. It seems I'am a bit tired 😪
cslashm
force-pushed
the
AddVersionCheck
branch
from
59109cf
to
430ff45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.