rpc: make wide_difficulty hexadecimal #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be friendlier for clients which don't have bignum support
hyc
approved these changes
Apr 5, 2019
vtnerd
reviewed
Apr 8, 2019
| std::string hex(difficulty_type v) | ||
| { | ||
| static const char chars[] = "0123456789abcdef"; | ||
| std::string s; |
There was a problem hiding this comment.
A call to reserve will constrain the number of allocations.
| if (s.empty()) | ||
| s += "0"; | ||
| std::reverse(s.begin(), s.end()); | ||
| return "0x" + s; |
There was a problem hiding this comment.
I would do this before the while loop, to prevent another possible allocation to handle the front insertion. Then do a if (s.size() == 2) s += "0"; std::reverse(s.begin() + 2, s.end());.
| @@ -74,7 +74,7 @@ namespace | |||
| void store_difficulty(cryptonote::difficulty_type difficulty, uint64_t &sdiff, std::string &swdiff, uint64_t &stop64) | |||
| { | |||
| sdiff = (difficulty << 64 >> 64).convert_to<uint64_t>(); | |||
| swdiff = difficulty.convert_to<std::string>(); | |||
| swdiff = cryptonote::hex(difficulty); | |||
There was a problem hiding this comment.
This type has a built-in function difficulty.str(0, std::ios_base::hex); which looks to have the same output, except the characters are upper case. The leading "0x" is also output. It does not use a std::stringstream internally, and the implementation looks to be similar in performance.
fluffypony
added a commit
that referenced
this pull request
Apr 15, 2019
cbf3224 rpc: make wide_difficulty hexadecimal (moneromooo-monero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be friendlier for clients which don't have bignum support