gitian: add FreeBSD support #6118
Conversation
|
@TheCharlatan ping |
hyc
force-pushed
the
giti2
branch
3 times, most recently
from
7d2a64b
to
19a6a7b
Compare
|
The point of this last round of patches was to make the dependencies reproducible as well. Previously they weren't identical because their tarball timestamps changed with the monero revision. Now they're constant, so they should have identical hashes regardless of future monero releases. |
hyc
force-pushed
the
giti2
branch
2 times, most recently
from
72b561f
to
2743f0b
Compare
hyc
force-pushed
the
giti2
branch
5 times, most recently
from
837fb8c
to
18a63ec
Compare
|
Despite your boost archiver patch, I still get these errors when I build locally: https://travis-ci.org/TheCharlatan/monero/jobs/612656939?utm_medium=notification&utm_source=github_status . |
| @@ -0,0 +1,17 @@ | |||
| freebsd_CC=clang-8 | |||
There was a problem hiding this comment.
Does this only work for clang-8? Would be nice to get the requirement down to a more generic clang version. It also requires the system to alias its clang installation to clang-8, so probably it should just work clang instead.
There was a problem hiding this comment.
clang-8 is the same version that was actually shipped on FreeBSD 11, which is why I set that. Ubuntu offers clang 7, 8, and 9 and I didn't want to leave it ambiguous.
There was a problem hiding this comment.
I'd leave it generic; it at least compiles fine on my clang 7 system.
There was a problem hiding this comment.
Given that C++ library ABIs are compiler version-dependent, I thought it was safest to use the same version FreeBSD uses. Did you run your binaries? I was able to run mine on a FreeBSD 11 VM.
|
I was focused on getting the Android build dependencies 100% reproducible (which they are now, at the moment) and I might have broken something else. The freeBSD build was already 100% before my recent changes. I'm re-running all the builds now to see what's broken. |
hyc
force-pushed
the
giti2
branch
3 times, most recently
from
8d36156
to
74db688
Compare
|
The android, freeBSD, and windows builds are now 100% identical. In the linux builds, the order of objects in libunwind.a still doesn't match; I've added an explicit sort command to libtool to try to fix that. A few of the native_* packages on Mac still don't match. |
hyc
force-pushed
the
giti2
branch
3 times, most recently
from
d15edaf
to
ed8e2c3
Compare
|
Linux dependencies are now 100% identical. Just have to look into these Mac discrepancies. |
hyc
force-pushed
the
giti2
branch
2 times, most recently
from
569248a
to
940d927
Compare
|
Fixed all of the Mac differences but one. There's a known bug in the old version of clang that the SDK uses. https://reviews.llvm.org/D50559 This bug makes the output of the Objective-C compiler completely non-deterministic. As a result, the libobjc2/arc.m file in the native_cctools package gives a different resulting .o file every time it's compiled. I don't see any solution to this with the version of clang in use. Supposedly turning off ASLR will also prevent this bug from happening, but I couldn't find any way to do so in the container. Trying to change Note that since this only affects one of the tools in the Mac toolchain, and apparently is only used when compiling objective C, it has never had any impact on the reproducibility of the Monero code. So there's nothing wrong with our previous Mac builds. I just wanted all the dependencies to be 100% identical so that in the future, if we get a build discrepancy, it's easier to narrow down which component diverged. (Instead of like the last time I had a problem, and didn't know if the problem was in my dependencies or in my Monero tree.) We'll just have to know to ignore differences in the Mac native_cctools package. |
Needed to invoke deterministic mode on some archivers
streamline, remove obsolete wrappers
get rid of sodium-darwin.mk special case, unify back with sodium.mk
Sort objects being archived
|
When all else fails, delete the offending binary... Mac dependencies are now 100% identical. |
By omitting the otool binary which is built non-deterministically. We don't use it anyway.
| @@ -4,6 +4,7 @@ $(package)_download_path=https://dl.bintray.com/boostorg/release/1.64.0/source/ | |||
| $(package)_file_name=$(package)_$($(package)_version).tar.bz2 | |||
| $(package)_sha256_hash=7bcc5caace97baa948931d712ea5f37038dbb1c5d89b43ad4def4ed7cb683332 | |||
| $(package)_dependencies=libiconv | |||
| $(package)_patches=fix_aroptions.patch | |||
There was a problem hiding this comment.
Just to note - this patch has now been merged into upstream boost. boostorg/build#507
No description provided.