epee: http_server_handlers_map2 macros to use fully qualified names #8348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows CI build error is unrelated and fixed by this PR: #8349 |
…ied names quick patch which fixes the issue where if you use some macros from `http_server_handlers_map2.h` you have to be in the `epee` namespace or it doesn't compile. Now can remove `using namespace epee;` from header file `core_rpc_server.h`, which caused a couple of name qualifying mistakes
jeffro256
force-pushed
the
epee_macro_namespace
branch
from
f50e7ec
to
a4cb77f
Compare
|
rebased against master |
selsta
approved these changes
May 23, 2022
mj-xmr
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick patch which fixes the issue where if you use some macros from
http_server_handlers_map2.hyou have to be in theepeenamespace or it doesn't compile. Now can removeusing namespace epee;from header filecore_rpc_server.h, which caused a couple of name qualifying mistakes down the line.