Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position independent amd64-51-30k amd64-64-24k #1

Merged
merged 1 commit into from
Dec 17, 2017

Conversation

vtnerd
Copy link
Collaborator

@vtnerd vtnerd commented Nov 30, 2017

This was initially PR'ed to the monero baseline, when @anonimal suggested a separate repo for the supercop code. This contains a base commit of files from supercop-20170904.tar which is apparently now outdated, but the relevant files here are unchanged. I then made the code -fPIC and -fPIE friendly.

@hyc @luigi1111 @Smooth @othe @ArticMine @fluffypony @kenshi84 @knaccc

    SHA-256 hash of supercop-20170904.tar :
        0dc3ff55ec39329ca645fb457a1b63d9459f8f22aec636bc24b8f5702ec53752
@anonimal
Copy link

Hi @vtnerd,

Referencing monero-project/monero#2317.

An important bit that was overlooked:

  1. Either you or I would create a supercop repo and pull the respective bits we need from ed25519 into said repo's master branch. The needed changes are then done to a respective monero and kovri branch.

So, we should first initialize this repo not with a README but with the original supercop code (kept in master for easy file checksum comparison) and then this PR is based off master into a monero branch; exactly like https://github.com/monero-project/unbound (minus the SVN-to-Git). Once that's done, kovri will then pull from this repo and work from branch kovri.

How does that sound?

@vtnerd
Copy link
Collaborator Author

vtnerd commented Dec 1, 2017

I don't see why having README files matters. Its trivial to ignore it when doing a folder comparison, especially since the primary concern is a comparison of the appropriate subdirectories. And I cannot issue a PR to github without an initial commit, so somebody with direct write access would have to commit the initial source code for me.

I also omitted large parts of the supercop code - the entire source is much larger and we are using a fraction of its contents. Do you think the entire source needs to be dumped into the repo? Seems like a waste to synchronize all of that content, but its not particularly difficult to do.

I will undo the relative addressing from this PR, I think you are correct that it should be in its own branch. Easier to keep upstream synchronized with that separation.

@anonimal
Copy link

anonimal commented Dec 1, 2017

And I cannot issue a PR to github without an initial commit, so somebody with direct write access would have to commit the initial source code for me.

Ok, no worries then, either of us can PR the additions to/removal of the README.

Do you think the entire source needs to be dumped into the repo?

No. Just what's needed. I'll PR any missing bits if needed.

I will undo the relative addressing from this PR, I think you are correct that it should be in its own branch. Easier to keep upstream synchronized with that separation.

Awesome, thanks @vtnerd.

@vtnerd
Copy link
Collaborator Author

vtnerd commented Dec 3, 2017

Probably shouldve bumped this, since removing one of the commits from the PR is not highlighted by the github UI.

@fluffypony fluffypony merged commit 65c4589 into monero-project:master Dec 17, 2017
fluffypony added a commit that referenced this pull request Dec 17, 2017
65c4589 Adding amd64-51-30k and amd64-64-24k from supercop 2017-09-04 (Lee Clagett)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants