Test against multiple versions of monero #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like what you did here and the work looks solid, but I am not sure why we should still support 0.17.x with the hard fork happening next week. |
Agree that with Monero hardforks version rotation will happen more often and in some days we will be able to drop the 17.x versions. I still think during transition times it is good to have a range tested, e.g. now. |
refring
pushed a commit
to refring/monero-rpc-rs
that referenced
this pull request
Oct 16, 2022
* chore: split CI into 3 files * style: format * ci: run multiple monero versions * test: verify a range of compatible versions * fix: don't check for specific versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #48
Test against versions:
0.17.3.0,0.17.3.2, and0.18.0.0