Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements Maybe.fromEmpty. close #213 #214

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

customcommander
Copy link
Contributor

@ulfryk I wasn't too sure how to go about properly integrating with Fantasy Land. I decided to go with a basic implementation to start with. Hope that's ok.

Copy link
Member

@ulfryk ulfryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

But I'll postpone merge until CI checks are fixed :)

@customcommander
Copy link
Contributor Author

@ulfryk Looking at the CI logs I can't seen anything wrong. Have I broken something somewhere else?

@ulfryk
Copy link
Member

ulfryk commented Jun 3, 2019

@customcommander - no you didn't

I have to fix it - changes in GH detached our CI some time ago, I have to fix it..

@ulfryk ulfryk merged commit 5344698 into monet:develop Jun 3, 2019
@customcommander customcommander deleted the maybe-from-empty branch June 3, 2019 14:18
@xanonid
Copy link

xanonid commented Mar 9, 2020

Maybe.fromEmpty is not yet added to src/monet.d.ts

@customcommander
Copy link
Contributor Author

Oops - totally overlooked TypeScript definitions. Sorry :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants