Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements Maybe.fromEmpty. close #213 #214

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
2 participants
@customcommander
Copy link
Contributor

commented Jun 3, 2019

@ulfryk I wasn't too sure how to go about properly integrating with Fantasy Land. I decided to go with a basic implementation to start with. Hope that's ok.

@ulfryk

ulfryk approved these changes Jun 3, 2019

Copy link
Member

left a comment

Looks Good!

But I'll postpone merge until CI checks are fixed :)

@customcommander

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@ulfryk Looking at the CI logs I can't seen anything wrong. Have I broken something somewhere else?

@ulfryk

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

@customcommander - no you didn't

I have to fix it - changes in GH detached our CI some time ago, I have to fix it..

@ulfryk ulfryk merged commit 5344698 into monet:develop Jun 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@customcommander customcommander deleted the customcommander:maybe-from-empty branch Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.