Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript setup #11

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Typescript setup #11

merged 1 commit into from
Oct 24, 2019

Conversation

rebzden
Copy link
Collaborator

@rebzden rebzden commented Oct 24, 2019

No description provided.

ulfryk
ulfryk reviewed Oct 24, 2019
View reviewed changes
tsconfig.json
"target": "es6",
"sourceMap": true,
"lib": ["es6"]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is strict: true ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ulfryk
ulfryk reviewed Oct 24, 2019
View reviewed changes
packages/core/src/core.ts Outdated
@@ -0,0 +1 @@
export const x = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line at the end of file :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@rebzden rebzden merged commit 0dbd52d into develop Oct 24, 2019
@ulfryk ulfryk deleted the typescript-setup branch October 24, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfryk ulfryk ulfryk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebzden @ulfryk