[DEV APPROVED] Reorganise MAS-maintained gems in Gemfile #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among the ungrouped gems, list the MAS ones separately. This is useful for identifying which repos need updating when applying a change across all Frontend dependencies, eg - a Ruby version bump.
rnalexander
approved these changes
Jan 4, 2019
margOnline
reviewed
Jan 4, 2019
Among the MAS gems, list tools (engines) and dependencies separately. Also, move validates_url further up so it's listed alongside other 3rd party dependencies.
|
@margOnline Yes, I think it is. Added a commit. |
margOnline
approved these changes
Jan 4, 2019
margOnline
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among the ungrouped gems, list the MAS ones separately. This is useful
for identifying which repos need updating when applying a change across
all Frontend dependencies, eg - a Ruby version bump.