-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme #1779
Comments
From wxWidgets blog about Mac and dark theme:
|
I'm using windows, that's why I wrote here. |
@vomikan this one looks great. For what I understand, though, there's a lot of techie work involved to achieve this look :( Is there anyway to share the css file you're using? I'm using Windows 10. Thanks! |
Hi there, It would working only on Linux or Mac. Unfortunatly, on Windows Black theme does not change app color settings. |
Looks great! Well done! 👍 👌🤝👏 Taking latest snapshot. Edit: I didn't see this new theme? Do we have to drop the theme file somewhere? |
fix(#1779): extra support for dark theme
@reddyshyam Try this with the latest build - https://mmex.ipx.co.uk/dark-mode.mmextheme |
Thanks @whalley. 👍 Looks awesome on windows too. Font sizes other than homepage are a tad larger. May be fine tuning is required? Now I only wish the MMex icon can get an overhaul. 🙂 |
Sure we can fine tune over time. I’ll get it added as a system theme so we can get more people to test. |
I'm afraid I'll have to make a separate theme for Windows. |
What’s the issue on Windows? @reddyshyam seemed to imply it works fine on Windows, keen to make sure the themes are platform agnostic if possible. |
You need to:
That at least works in MacOS. The trick is not to switch to dark mode whilst MMEX is running as it will not pick up the change. Does that solve things? |
Yes, its a shame the Win implementation does not take the dark OS elements. Think I'll leave it there for now and perhaps we tag as Windows issue / on hold. I can make a note against the theme that it works best on non-Windows systems. |
Also, please, update submodule |
fix(#1779): pickup latest theme repo
Sorry @whalley, I missed out the conversation. All the issues pointed above were what I thought minor tweaks. Hope it wasn't too much trouble. Thanks @vomikan for helping make it better. Took the latest snapshot (fix(#1779): pickup latest theme repo) and the theme looks brilliant to me. 👍 👌👏. I am keeping it. 🙂 Thanks for all the hardwork. Appreciate it. 🙏 |
@grumpy235 That coloring looks very odd. The layout should be as @vomikan posted earlier, are you using the latest build? At least that is how it looks on my Windows test box. |
Mine looks exactly like this 👆 and I dont use Windows dark mode too. |
Ah yes, I see the difference but Light mode isn't bad either. 🙂 |
@whalley - all I did is Git applied your latest fixes under VS2019 and recompiled but I will re-download the master and compile again. As it stands at present if I hover over the white lines then they turn black. |
@grumpy235 Sounds like you need to update the themes sub module. |
@whalley - I guess so still on a learning curve with Git, last source manager I used in anger was Panvalet in the '70s ! |
|
The mobile app has dark theme and it would be great if I can set a dark theme on my PC also.
Thanks :)
The text was updated successfully, but these errors were encountered: