Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #1779

Closed
k2ironman opened this issue Aug 25, 2018 · 41 comments
Closed

Dark theme #1779

k2ironman opened this issue Aug 25, 2018 · 41 comments
Assignees
Labels
enhancement linux related to Linux platforms mac related to OSX / MacOS theme Theme related
Milestone

Comments

@k2ironman
Copy link

The mobile app has dark theme and it would be great if I can set a dark theme on my PC also.
Thanks :)

@slodki
Copy link
Contributor

slodki commented Aug 25, 2018

For Linux and Mac it's very easy - you can change GTK+ theme in the system settings:

mmex

@slodki slodki added question win related to Windows pltform labels Aug 25, 2018
@slodki
Copy link
Contributor

slodki commented Aug 26, 2018

From wxWidgets blog about Mac and dark theme:

Stefan Csomor, Daniel Kulp and others have added supported for the upcoming next macOS version: 10.14, a.k.a. Mojave, and, notably, its new dark mode. Some problems might still remain, so please test your Mac applications with Mojave and let us know if you notice anything wrong.

@k2ironman
Copy link
Author

I'm using windows, that's why I wrote here.

@vomikan
Copy link
Member

vomikan commented May 12, 2020

@vomikan
Copy link
Member

vomikan commented May 12, 2020

image

@valsamis-d
Copy link

image

@vomikan this one looks great. For what I understand, though, there's a lot of techie work involved to achieve this look :( Is there anyway to share the css file you're using? I'm using Windows 10. Thanks!

@vomikan
Copy link
Member

vomikan commented Aug 8, 2020

Hi there,

It would working only on Linux or Mac. Unfortunatly, on Windows Black theme does not change app color settings.
But you can change homepage color settings by merge
https://gist.githubusercontent.com/ZachSaucier/8295d9dc926d7064ff0d4f3f04b35b55/raw/06a8cc03bbdbb7e36f7ae192f834226320f752cd/dark-theme.css
file into res\master.css

@whalley
Copy link
Member

whalley commented Jun 10, 2021

Have developed a Dark Theme that I will release shortly... Example as below using some test data

image

CleanShot 2021-06-10 at 01 33 53

CleanShot 2021-06-10 at 01 40 24

@reddyshyam
Copy link

reddyshyam commented Jun 10, 2021

Looks great! Well done! 👍 👌🤝👏

Taking latest snapshot.

Edit: I didn't see this new theme? Do we have to drop the theme file somewhere?

vomikan added a commit that referenced this issue Jun 10, 2021
fix(#1779): extra support for dark theme
@vomikan vomikan modified the milestones: v1.5.4, v1.5.3 Jun 10, 2021
@whalley
Copy link
Member

whalley commented Jun 10, 2021

@reddyshyam Try this with the latest build - https://mmex.ipx.co.uk/dark-mode.mmextheme

@reddyshyam
Copy link

@reddyshyam Try this with the latest build - https://mmex.ipx.co.uk/dark-mode.mmextheme

Thanks @whalley. 👍 Looks awesome on windows too. Font sizes other than homepage are a tad larger. May be fine tuning is required?

Now I only wish the MMex icon can get an overhaul. 🙂

@whalley
Copy link
Member

whalley commented Jun 10, 2021

Sure we can fine tune over time. I’ll get it added as a system theme so we can get more people to test.

@vomikan
Copy link
Member

vomikan commented Jun 10, 2021

I'm afraid I'll have to make a separate theme for Windows.

@whalley
Copy link
Member

whalley commented Jun 10, 2021

I'm afraid I'll have to make a separate theme for Windows.

What’s the issue on Windows? @reddyshyam seemed to imply it works fine on Windows, keen to make sure the themes are platform agnostic if possible.

@grumpy235
Copy link

grumpy235 commented Jun 10, 2021

@whalley Nice theme.
Just downloaded latest master,compiled on Win10 and VS2019 and Account View I only see every other line

Capture

Click on non-visible line, background lightens and text is faintly visible in black

Capture1

I wonder if that is what @vomikan was refering to ?

@whalley
Copy link
Member

whalley commented Jun 10, 2021

You need to:

  1. Enable Dark-Mode in Windows 10
  2. Start MMEX
  3. Enable the dark-mode theme in MMEX
  4. Restart MMEX

That at least works in MacOS. The trick is not to switch to dark mode whilst MMEX is running as it will not pick up the change.

Does that solve things?

vomikan added a commit to vomikan/moneymanagerex that referenced this issue Jun 10, 2021
@vomikan vomikan added enhancement theme Theme related and removed question win related to Windows pltform labels Jun 10, 2021
@vomikan
Copy link
Member

vomikan commented Jun 10, 2021

You also need to change the color of each button. And still a lot of objects will remain, which do not change the color and the color is not inherited from the OS color scheme.

image

image

@whalley
Copy link
Member

whalley commented Jun 10, 2021

Yes, its a shame the Win implementation does not take the dark OS elements. Think I'll leave it there for now and perhaps we tag as Windows issue / on hold. I can make a note against the theme that it works best on non-Windows systems.

@vomikan
Copy link
Member

vomikan commented Jun 10, 2021

Also, please, update submodule
moneymanagerex/themes@4565e96

whalley pushed a commit that referenced this issue Jun 10, 2021
fix(#1779): win specific update
whalley pushed a commit that referenced this issue Jun 10, 2021
fix(#1779): pickup latest theme repo
@grumpy235
Copy link

I think I'll stay with colorful for the time being. Changes now make the data visible although a little bright :-) I get the following with and without windows dark mode

Capture2

Still better than when I started with screens when you could have any colour as long as it was green!

@reddyshyam
Copy link

Sorry @whalley, I missed out the conversation. All the issues pointed above were what I thought minor tweaks. Hope it wasn't too much trouble. Thanks @vomikan for helping make it better.

Took the latest snapshot (fix(#1779): pickup latest theme repo) and the theme looks brilliant to me. 👍 👌👏. I am keeping it. 🙂

Thanks for all the hardwork. Appreciate it. 🙏

@whalley
Copy link
Member

whalley commented Jun 11, 2021

@grumpy235 That coloring looks very odd. The layout should be as @vomikan posted earlier, are you using the latest build? At least that is how it looks on my Windows test box.
image

@reddyshyam
Copy link

@grumpy235 That coloring looks very odd. The layout should be as @vomikan posted earlier, are you using the latest build? At least that is how it looks on my Windows test box.
image

Mine looks exactly like this 👆 and I dont use Windows dark mode too.

@whalley
Copy link
Member

whalley commented Jun 11, 2021

Mine looks exactly like this 👆 and I dont use Windows dark mode too.

Yes the forcing of panel colors works well on machines not using OS dark mode. But looks really pretty in Dark Mode on MacOS.

** dark-mode theme with MacOS 'Light' mode**
CleanShot 2021-06-11 at 13 05 11@2x

** dark-mode theme with MacOS 'Dark' mode**
CleanShot 2021-06-11 at 13 06 10@2x

@reddyshyam
Copy link

Mine looks exactly like this 👆 and I dont use Windows dark mode too.

Yes the forcing of panel colors works well on machines not using OS dark mode. But looks really pretty in Dark Mode on MacOS.

** dark-mode theme with MacOS 'Light' mode**
CleanShot 2021-06-11 at 13 05 11@2x

** dark-mode theme with MacOS 'Dark' mode**
CleanShot 2021-06-11 at 13 06 10@2x

Ah yes, I see the difference but Light mode isn't bad either. 🙂

@grumpy235
Copy link

grumpy235 commented Jun 11, 2021

@whalley - all I did is Git applied your latest fixes under VS2019 and recompiled but I will re-download the master and compile again. As it stands at present if I hover over the white lines then they turn black.

@grumpy235
Copy link

@whalley refreshed my repository and now I get the same as @vomikan 😊
Had issues before with themes and VS2019/Git, downloading the commits and recompiling sometimes does not work - no big deal

@whalley
Copy link
Member

whalley commented Jun 11, 2021

@grumpy235 Sounds like you need to update the themes sub module.

@grumpy235
Copy link

@whalley - I guess so still on a learning curve with Git, last source manager I used in anger was Panvalet in the '70s !

@vomikan
Copy link
Member

vomikan commented Jun 11, 2021

@grumpy235

git submodule update --init --recursive

@vomikan vomikan modified the milestones: v1.5.3, v1.5.4 Jun 12, 2021
@vomikan
Copy link
Member

vomikan commented Jun 12, 2021

image

@vomikan vomikan closed this as completed Jun 12, 2021
@vomikan vomikan added linux related to Linux platforms mac related to OSX / MacOS labels Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement linux related to Linux platforms mac related to OSX / MacOS theme Theme related
Projects
None yet
Development

No branches or pull requests

8 participants