Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean and Date custom field improvements #4987

Closed
3 of 7 tasks
tactilis opened this issue Aug 28, 2022 · 21 comments
Closed
3 of 7 tasks

Boolean and Date custom field improvements #4987

tactilis opened this issue Aug 28, 2022 · 21 comments

Comments

@tactilis
Copy link

MMEX version:

  • 1.5.20 Beta

Operating System:

  • Windows
  • Mac OSX
  • Linux

Description of the bug

  1. The control (a checkbox) for setting a Boolean custom field value is not consistent with the display of the Boolean value in the UDCF column. Also, the control is currently positioned on the far right and looks out of place.

  2. The format of dates in the UDCF column does not match the selected in Options | General | Date Format.

Reproduction

Is the bug reproducible?

  • Always
  • Randomly
  • Happened only once

Reproduction steps:

Expected result:

  1. The control for Boolean should be a FALSE/TRUE dropdown that is left aligned.
  2. The custom control date format on the transaction list should match the format of the transaction date.

image

@whalley whalley self-assigned this Aug 29, 2022
@whalley whalley added this to the v1.5.20 milestone Aug 29, 2022
whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
@whalley
Copy link
Member

whalley commented Aug 29, 2022

  • Date format fixed...
  • Have left the boolean as a checkbox (now left justified on entry dialog) but it is now presented as a cross or tick in the account view. If the user wants FALSE/TRUE they can use the use the 'SINGLECHOICE' field type and define a boolean themselves.

@whalley whalley added the fixed label Aug 29, 2022
whalley added a commit that referenced this issue Aug 29, 2022
fix(#4987): formatting for custom fields
whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
@tactilis
Copy link
Author

Now testing 1.5.20-Beta.1 commit: 9377dc1 (2022-08-29)

Opening the same database as above, resulted in:

image

@whalley
Copy link
Member

whalley commented Aug 29, 2022

I get:
CleanShot 2022-08-29 at 17 49 02

Unicode issue?

@whalley
Copy link
Member

whalley commented Aug 29, 2022

I need to also make the same change to the transaction report.

@vomikan
Copy link
Member

vomikan commented Aug 29, 2022

Just FYI
U+2713 ✓
U+2717 ✗

@tactilis
Copy link
Author

Unicode issue?

Just FYI U+2713 ✓ U+2717 ✗

Yep. Checked that.

What font is used in the transaction list?

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
@whalley
Copy link
Member

whalley commented Aug 29, 2022

@vomikan Do you have the same issue with U+2713 and U+27217 being used on the list control to show the boolean status?

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
vomikan added a commit that referenced this issue Aug 29, 2022
@vomikan
Copy link
Member

vomikan commented Aug 29, 2022

There are no issues in the report and transaction panel.

|image image

@vomikan
Copy link
Member

vomikan commented Aug 29, 2022

image

here would be better to use wxRadioButton

@whalley
Copy link
Member

whalley commented Aug 29, 2022

image

here would be better to use wxRadioButton

Yes, it may be a bit more obvious to have a False/True radio button.

whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
whalley pushed a commit to whalley/moneymanagerex that referenced this issue Aug 29, 2022
@whalley
Copy link
Member

whalley commented Aug 29, 2022

Now testing 1.5.20-Beta.1 commit: 9377dc1 (2022-08-29)

Opening the same database as above, resulted in:

image

Have tested latest build on my Dev Win11 VM and get the same results....

@whalley
Copy link
Member

whalley commented Aug 30, 2022

@tactilis Please test latest build. The unicode characters now work fine on my Win VM.

whalley added a commit that referenced this issue Aug 30, 2022
@tactilis
Copy link
Author

tactilis commented Aug 30, 2022

Now testing 1.5.20-Beta.1 commit: 5490458 (2022-08-30)

@whalley The cross and tick are now displayed, although the tick looks 'odd'. It's not the nice looking tick shown in your and @vomikan's screenshots:

image

It's the same symbol that is shown (on my PC) in the Currency dialog:

image

From @vomikan's earlier comment, it is clear that my PC is capable of displaying the tick correctly:

image

So there's something different happening in MMEX. Font related perhaps?

@whalley
Copy link
Member

whalley commented Aug 30, 2022

From @vomikan's earlier comment, it is clear that my PC is capable of displaying the tick correctly:

I suspect that is how it is presented in the transaction report webview.

@tactilis
Copy link
Author

tactilis commented Aug 30, 2022

So there's something different happening in MMEX. Font related perhaps?

I've just tried pasting the characters into the MMEX Notes field and get the same odd looking tick:

image

Then I tried pasting the same text into several other applications and they all display the good looking tick:

image

@tactilis
Copy link
Author

tactilis commented Aug 30, 2022

From @vomikan's earlier comment, it is clear that my PC is capable of displaying the tick correctly:

I suspect that is how it is presented in the transaction report webview.

Yes.

image

Actually, it's a slightly different tick to that shown in my browser and in other apps, but it's still good looking.

@vomikan vomikan modified the milestones: v1.5.21, v1.5.20 Aug 30, 2022
@whalley
Copy link
Member

whalley commented Aug 30, 2022

Have you changed any system font settings on your Windows machine? On a base Windows 11 install it looks fine:
CleanShot 2022-08-30 at 11 03 50@2x

Have tried on corporate work laptop and also works fine...

@tactilis
Copy link
Author

Have you changed any system font settings on your Windows machine?

I'm not aware of any "system font settings" that can be changed.

I certainly haven't removed any fonts from the system.

@tactilis
Copy link
Author

The puzzling thing (to me) is that the tick displays OK in other applications I paste the character into.

@whalley
Copy link
Member

whalley commented Aug 30, 2022

Not sure what else we can do to help, you may need to investigate/experiment a bit... or may need to live with the 'ugly' tick :-). I just booted up an old Win10 laptop I have and installed MMEX. The tick looks the same as my Win 11 VM.

@whalley whalley closed this as completed Aug 30, 2022
@tactilis
Copy link
Author

you may need to investigate/experiment a bit

In case it helps anyone else...

I have found out what font is causing the ugly tick, but not yet why it is being used for the tick and cross characters in MMEX on my PC.

Using Chrome I went to https://wordmark.it and entered ✓ ✗ and selected 'Your Fonts'.

Scrolling, through the fonts, revealed that the offending one was the Meiryo font family.

image

Looking in the Fonts folder shows that Meiryo and Meiryo UI is a Japanese font. Apparently they are installed by Microsoft as part of Office.

image

Unfortunately, you cannot simply delete Meiryo and Meiryo UI because they are protected system fonts:

image

WikiHow shows how to work around this https://www.wikihow.com/Delete-Protected-System-Fonts-in-Windows-7

The steps to take ownership of the font and delete it are fairly lengthy. I don't plan on doing this now, as I will be moving to Windows 11 soon (new laptop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants