fix(#4987): bug fix #4993
Merged
fix(#4987): bug fix #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tactilis
reviewed
Aug 29, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @tactilis and @whalley)
src/mmcheckingpanel.cpp line 208 at r1 (raw file):
full_tran.UDFC04_Type = Model_CustomField::FIELDTYPE::UNKNOWN; full_tran.UDFC05_Type = Model_CustomField::FIELDTYPE::UNKNOWN; full_tran.UDFC02_val = -DBL_MAX;
Seem to have lost:
full_tran.UDFC01_val = -DBL_MAX;
Code quote:
full_tran.UDFC02_val = -DBL_MAX;
full_tran.UDFC03_val = -DBL_MAX;
full_tran.UDFC04_val = -DBL_MAX;
full_tran.UDFC05_val = -DBL_MAX;
whalley
commented
Aug 29, 2022
There was a problem hiding this comment.
Good job somebody is checking my work!
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @tactilis and @whalley)
tactilis
reviewed
Aug 29, 2022
There was a problem hiding this comment.
😄
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @tactilis and @whalley)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not forget to update the mmex.pot file and write information about the fixed bug in the prerelease page.
This change is