-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not possible to delete payee or category if present in deleted transactions #5296
Comments
I think the safest and least surprising thing for the user, is your suggestion:
While on the topic of user confusion arising from the new Deleted Transactions functionality:
I've raised #5298 , which discusses this. |
Fixed in PR #5307. Deleting a category or payee used only in deleted transactions will now show a warning confirmation dialog. If the user proceeds both the selected category/payee as well as the associated deleted transactions are removed permanently. |
Do we need to add some kind of "Tip" saying the user can find the deleted transactions in the view found on the Nav Panel or enabled via View -> Show Deleted Transactions? |
Let's wait for a request from users. |
fix(#5296): Allow delete categories & payees used in deleted transactions
I think this needs to be reopened. On the v16 upgrade the columns are initialized with NULL, but the selection find(DELETEDTIME(wxEmptyString)) does not pick up NULL values, so you are able to delete categories which are used. |
Possible to change the v16 upgrade script to default to empty string?
|
Will need to create a v17 and upgrade from v16 to v17 as v16 is out in the wild now. |
It can be fixed by code. Instead of pulling using DELETEDTIME(wxEmptyString) we would have to pull all entries then loop through and check DELETEDTIME one at a time and break when it finds a blank/null value. Would this be cleaner than a v17 migration? |
That code change should be fine. It's obviously less elegant/efficient but the check is done quite rarely anyway. |
PR #5336 |
Shouldn't be much performance hit since all it needs to find is the first non-deleted transaction which is very likely the first in the data set. |
In the v17 upgrade script we can update NULL to '' then go back to the cleaner code in 1.6.2.
|
fix(#5296): fix for DELETEDTIME = NULL
Following the implementation of #2963 it is not possible to delete:
This may be confusing for users who are unfamiliar with this new feature or who never enable the view of deleted transactions.
Options:
The text was updated successfully, but these errors were encountered: