Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User confusion regarding Deleted Transactions node in Navigation tree #5298

Closed
tactilis opened this issue Nov 2, 2022 · 18 comments
Closed
Assignees
Milestone

Comments

@tactilis
Copy link

tactilis commented Nov 2, 2022

Problem to be solved

Following the implementation of #2963, I anticipate that there will be confusion for some users, which leads to a flurry of forum questions asking "Where can I see my deleted transactions".

Consider:

  1. The user deletes a transaction for the first time after upgrading to 1.6.1:

image

  1. They click Yes and are presented with:

image

  1. They ask "Where did my transaction go?" - they have forgotten the exact wording of the delete confirmation message.
    It's not at all obvious that they now need to go to the View menu to turn on the display of the Deleted Transactions:

image

We know from other forum questions that many users do not systematically explore all the menus or the Options in MMEX, so will not easily find the View | Display Deleted Transactions menu item.

Proposed solution

I propose possible 2 solutions:

  1. Always show the Deleted Transactions entry in the Navigation tree and do not have a View | Display Deleted Transactions menu item.

  2. Set View | Display Deleted Transactions on for all new MMEX installations/upgrades but don't override the setting in the future if the user turns it off.

I favour the simplicity of solution 1 because:

  • I cannot imagine that anyone is going to get upset by the presence of a Deleted Transactions node in the Navigation tree.
  • The Deleted Transactions node is a reminder to users that they can easily recover deleted transactions.
  • Too many View menu items and Options leads to 'decision fatigue for users. It is often simpler to implement what we believe will satisfy 99% of users and then, if there are any vocal requests to hide the Deleted Transactions node, we consider whether to implement it.
@whalley
Copy link
Member

whalley commented Nov 2, 2022

Always show the Deleted Transactions entry in the Navigation tree and do not have a View | Display Deleted Transactions menu item.

+1 for this (from the two options)

But, can I throw another option out there....

99% of the time people are not interested in the deleted transactions, much like the 'Trash' on your computer. Because of this I would question whether we should use space in the Navigation tree for this. On your PC you don't typically have the 'Trash' as part of your file browser, but it's there to access if needed.

Perhaps we just allow access via Tools / Deleted Transactions and add it to the toolbar ?

@whalley whalley added this to the v1.6.1 milestone Nov 2, 2022
@tactilis
Copy link
Author

tactilis commented Nov 2, 2022

99% of the time people are not interested in the deleted transactions, much like the 'Trash' on your computer.

Agreed.

Because of this I would question whether we should use space in the Navigation tree for this.

For me, it's a matter of discoverability. It's only one node and, like the various Account nodes, it opens a 'view' in the right hand transactions panel.

But, can I throw another option out there....
Perhaps we just allow access via Tools / Deleted Transactions and add it to the toolbar ?

My argument against this suggestion is that, because the Deleted Transactions list is a view in right hand panel, it should appear in the Navigation tree and it should be highlighted whenever the Deleted Transactions list is displayed.

Consider this similar use of Tools | Transaction Report Filter or the corresponding toolbar button...

The video shows:

  1. Acc 1 highlighted and it's transactions displayed.
  2. Clicking Transaction Report Filter on the toolbar.
  3. Display of the Transaction Report - but Acc 1 is still highlighted
  4. Repeated attempts to switch back to Acc 1 by single clicking in the Nav tree - the clicks have no effect.
  5. Finally I double click on Acc 1, which does change the view.
mmex_2guwE37rhw.mp4

Arguably, this is a bug and we should fix it by refreshing the Nav tree with Transaction Report highlighted when OK is pressed on the Transaction Report Filter dialog. I can raise a new issue for this if you wish.

But now apply the same logic to your Tools | Deleted Transactions / toolbar button suggestion. If you don't have a node in the Nav tree, then you will have no option but to leave the tree showing Acc 1 (in my example). This is wrong and confusing behaviour IMO when the right hand panel shows deleted transactions.

@vomikan
Copy link
Member

vomikan commented Nov 2, 2022

We can make the following scenario.

In the global settings, add a choice: delete to the trash or permanently.
In the navigation tree, display the basket if it is not empty. Or display it always. We can make 2 icons - an empty basket and a filled one.

So it will be clearer for everyone.

@vomikan
Copy link
Member

vomikan commented Nov 2, 2022

A simple useful change is to make the trash display by default.
image

@tactilis
Copy link
Author

tactilis commented Nov 2, 2022

In the global settings, add a choice: delete to the trash or permanently.

Why add a Delete to trash/Delete permanently option? It's more complexity and another decision that the user has to think about?

The 'trash' (Deleted Transactions) feature just works. There is no downside to it.
No decisions have to be made. Deleted transactions are automatically purged after a period of time.

It's easy to keep adding options on the basis that "It gives users a choice" but there is a cost (maintainability / cluttered UI / user decision fatigue) to every new option that is added.

@whalley
Copy link
Member

whalley commented Nov 2, 2022

In the global settings, add a choice: delete to the trash or permanently.

Why add a Delete to trash/Delete permanently option? It's more complexity and another decision that the user has to think about?

It's already there... You set the retention period to ZERO,

CleanShot 2022-11-02 at 13 04 25@2x

@whalley
Copy link
Member

whalley commented Nov 2, 2022

Arguably, this is a bug and we should fix it by refreshing the Nav tree with Transaction Report highlighted when OK is pressed on the Transaction Report Filter dialog. I can raise a new issue for this if you wish.

Yes, please do.

@Dandy64
Copy link

Dandy64 commented Nov 2, 2022

The simplest way is just to add a couple of sentences to the Help.

I have been using the MMX since 2019 and I have never needed to see the deleted transactions yet. Anyway, if I need it for any weird reason, I would obviously look at the View menu.

But since tactilis thinks this can confuse users, I would prefer the 2nd option.
Set View | Display Deleted Transactions on for all new MMEX installations/upgrades but don't override the setting in the future if the user turns it off.

@tactilis
Copy link
Author

tactilis commented Nov 2, 2022

I have been using the MMX since 2019 and I have never needed to see the deleted transactions yet.

The capability has not been released yet.

@Dandy64
Copy link

Dandy64 commented Nov 2, 2022

The capability has not been released yet.

It doesn't matter. I have never needed this capability.

@rmelillo76
Copy link

How about something like this - we have an icon that displays on the transaction grid itself when there are deleted transactions that can be restored?
image

And as a bonus (if not overly complex), indicate how many there are. We could even hide the icon when there are none.
image

I think this takes care of the discoverability issue, as well as tidying up the menu and navigation panel. Just an idea, let me know what you think.

@tactilis
Copy link
Author

tactilis commented Nov 2, 2022

@rmelillo76

Just an idea, let me know what you think.

I think it's an interesting idea.

But it breaks the underlying mental model that the item that is currently highlighted in the Navigation tree determines the view that is shown in the right hand panel.

The Deleted Transactions view does not 'belong' a specific account. It is a global view, independent of the account that is selected in the tree.

However, I do like the idea that the Deleted Transactions icon could automatically appear (in the Navigation tree) when there are any deleted transactions and be removed when all deleted transactions have been purged (or restored).

This would also cater for @Dandy64's wish never to use or see Deleted Transactions (or the icon); they just set the 'Days to retain deleted transactions' Option to 0, which causes transactions to be permanently deleted straight away. The Nav tree icon will then never appear.

@rmelillo76
Copy link

But it breaks the underlying mental model that the item that is currently highlighted in the Navigation tree determines the view that is shown in the right hand panel.

The Deleted Transactions view does not 'belong' a specific account. It is a global view, independent of the account that is selected in the tree.

I agree with you @tactilis. I hadn't fully thought about what would be displayed to the user immediately after clicking the button. My initial thought was that the button and view would be scoped to items that had been deleted from the account currently selected (or all if on the Full Transactions panel). The Deleted transactions panel would then display for that account, but I can see where this now becomes overly complicated and not consistent with the original goals.

@n-stein
Copy link
Contributor

n-stein commented Nov 2, 2022

However, I do like the idea that the Deleted Transactions icon could automatically appear (in the Navigation tree) when there are any deleted transactions and be removed when all deleted transactions have been purged (or restored).

I like this and it is very simple to implement.

How about some combination of the two? Set the default to "Display Deleted Transactions". When there are deleted transactions it will display in the Nav Panel, otherwise will be hidden. If the user manually turns off the display via the "View" menu, it won't show up in the Nav Panel even if there are deleted transactions. I would personally use it like this to avoid Nav Panel clutter while still using the deleted transactions feature "just in case".

@vomikan
Copy link
Member

vomikan commented Nov 2, 2022

How about some combination of the two? Set the default to "Display Deleted Transactions". When there are deleted transactions it will display in the Nav Panel, otherwise will be hidden. If the user manually turns off the display via the "View" menu, it won't show up in the Nav Panel even if there are deleted transactions. I would personally use it like this to avoid Nav Panel clutter while still using the deleted transactions feature "just in case".

That's exactly what I would do.

@n-stein
Copy link
Contributor

n-stein commented Nov 2, 2022

PR #5300

vomikan added a commit that referenced this issue Nov 2, 2022
fix(#5298): Default to autoshow "Deleted Transactions" node
@vomikan vomikan added the fixed label Nov 2, 2022
@vomikan
Copy link
Member

vomikan commented Nov 2, 2022

@n-stein one litle thing... It is necessary to show the home page after deleting all deleted transactions.
Thank you in advance.

image

@n-stein
Copy link
Contributor

n-stein commented Nov 2, 2022

PR #5301 will send you back to home if you restore or purge all the deleted items.

vomikan added a commit that referenced this issue Nov 2, 2022
fix(#5298): Return to Home from Deleted Trans view
@whalley whalley closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants