Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMB Files (*.mmb): 1. Add a space ; and, 2. allow translation #6481

Closed
ovari opened this issue Jan 24, 2024 · 6 comments
Closed

MMB Files (*.mmb): 1. Add a space ; and, 2. allow translation #6481

ovari opened this issue Jan 24, 2024 · 6 comments
Assignees
Milestone

Comments

@ovari
Copy link
Contributor

ovari commented Jan 24, 2024

Description of the bug

  1. Menu Bar, File, New Database.
  2. Please add a space to change MMB Files(*.mmb) to MMB Files (*.mmb).
  3. Please allow MMB Files (*.mmb) to be translatable.

Thank you

image


Money Manager Ex
• Version: 1.7.1-Beta.1 64-bit
• Built on: Jan 20 2024 03:16:22
• Database version: 19 (aes128cbc)
• Git commit: dbfb7dacd (2024-01-20)
• Git branch: master
MMEX is using the following support products:
• wxWidgets 3.2.4 (wxGTK 3.24)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/8.5.0-DEV OpenSSL/3.1.4 zlib/1.3 nghttp2/1.56.0
• gettext 0.22
• apexcharts.js
Built with:
• CMake 3.28.1
• GNU Make 4.4.1
• GCC 13.2.0
Running on:
• GNOME.45 (Flatpak runtime)
• GNOME 45 (Flatpak runtime) ""
• Linux 5.15.0-91-generic x86_64
• X-Cinnamon (X11)
• System Locale: en_AU.UTF-8
• User Interface Language: en_US.UTF-8
• 1368x768 24-bit 96x96ppi
vomikan added a commit that referenced this issue Jan 24, 2024
fix(#6481): `MMB Files (*.mmb)`: 1. Add a space ` `; and, 2. allow translation
@whalley
Copy link
Member

whalley commented Jan 24, 2024

@ovari If we are making these changes perhaps better wording would be.... "MMEX Database" rather than "MMB Database" it seems clearer.

@n-stein
Copy link
Contributor

n-stein commented Jan 24, 2024

Also, this text needs to be wrapped in _( ) if it should be available for translation.

, "Encrypted MMB Database (*.emb)|*.emb"

@rmelillo76
Copy link

Do you guys think this is a risky string to allow translation? Allowing it to be controlled externally could break the open file dialog if the placement of the pipe and wildcards are not done 100% perfect. If the goal is to allow "database "and "file" to be translated, maybe only a substring should be wrapped.

@whalley
Copy link
Member

whalley commented Jan 24, 2024

Do you guys think this is a risky string to allow translation? Allowing it to be controlled externally could break the open file dialog if the placement of the pipe and wildcards are not done 100% perfect. If the goal is to allow "database "and "file" to be translated, maybe only a substring should be wrapped.

Good point, I agreee.

@whalley whalley added this to the v1.7.1 milestone Jan 24, 2024
@rmelillo76
Copy link

Hi @ovari it looks like one or more of these changes broke the overnight build. It looks like there were syntax errors formatting the strings.

@n-stein
Copy link
Contributor

n-stein commented Jan 27, 2024

Pretty sure it's the missing \ escape characters before the double quotation marks causing the build failures.

whalley added a commit that referenced this issue Jan 31, 2024
@whalley whalley added the fixed label Jan 31, 2024
whalley added a commit that referenced this issue Feb 4, 2024
@whalley whalley closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants