Skip to content

Commit

Permalink
Merge pull request #6507 from ovari/master
Browse files Browse the repository at this point in the history
fix(#6481) feedback attempt #3
  • Loading branch information
whalley committed Feb 4, 2024
2 parents 0e8a67a + 94216d5 commit 2712626
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions src/budgetyeardialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ void mmBudgetYearDialog::CreateControls()
itemBoxSizer2->Add(itemBoxSizer5, 1, wxGROW|wxALL, 5);

wxButton* itemButton7 = new wxButton(this, wxID_ADD
, _("&Add Year"));
, _("Add &Year"));
itemBoxSizer5->Add(itemButton7, 0, wxALIGN_CENTER_VERTICAL);
mmToolTip(itemButton7, _("Add a new budget year"));

wxButton* itemBudgetMonth = new wxButton(this, ID_ADD_MONTH
, _("&Add Month"));
, _("Add &Month"));
itemBoxSizer5->Add(itemBudgetMonth, 0, wxALIGN_CENTER_VERTICAL | wxLEFT, 5);
mmToolTip(itemBudgetMonth, _("Add a new budget month"));

Expand Down
22 changes: 11 additions & 11 deletions src/mmchecking_list.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -459,10 +459,10 @@ void TransactionListCtrl::OnMouseRightClick(wxMouseEvent& event)
}
wxMenu menu;
if (!m_cp->isTrash_) {
menu.Append(MENU_TREEPOPUP_WITHDRAWAL, _("&New Withdrawal..."));
menu.Append(MENU_TREEPOPUP_DEPOSIT, _("&New Deposit..."));
menu.Append(MENU_TREEPOPUP_WITHDRAWAL, _("New &Withdrawal..."));
menu.Append(MENU_TREEPOPUP_DEPOSIT, _("New &Deposit..."));
if (Model_Account::instance().all_checking_account_names(true).size() > 1)
menu.Append(MENU_TREEPOPUP_TRANSFER, _("&New Transfer..."));
menu.Append(MENU_TREEPOPUP_TRANSFER, _("New &Transfer..."));

menu.AppendSeparator();

Expand Down Expand Up @@ -646,7 +646,7 @@ void TransactionListCtrl::OnMouseRightClick(wxMouseEvent& event)
menu.Append(MENU_TREEPOPUP_FIND, wxString::Format(_("&Find all transactions with %s '%s'"), (columnIsAmount ? _("Amount") : m_columns[column].HEADER), menuItemText));
}
if (!copyText_.IsEmpty())
menu.Append(MENU_TREEPOPUP_COPYTEXT, _("Copy Text to Clipboard"));
menu.Append(MENU_TREEPOPUP_COPYTEXT, _("Cop&y Text to Clipboard"));
}
}
}
Expand All @@ -662,23 +662,23 @@ void TransactionListCtrl::OnMouseRightClick(wxMouseEvent& event)
subGlobalOpMenuDelete->Append(MENU_TREEPOPUP_DELETE_FLAGGED, _("Delete Viewed \"Follow Up\" Transactions..."));
subGlobalOpMenuDelete->Append(MENU_TREEPOPUP_DELETE_UNRECONCILED, _("Delete Viewed \"Unreconciled\" Transactions..."));
}
menu.Append(MENU_TREEPOPUP_DELETE2, _("&Delete "), subGlobalOpMenuDelete);
menu.Append(MENU_TREEPOPUP_DELETE2, _("De&lete "), subGlobalOpMenuDelete);

if (!m_cp->isTrash_) {
menu.AppendSeparator();

wxMenu* subGlobalOpMenuMark = new wxMenu();
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKUNRECONCILED, _("Unreconciled"));
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKUNRECONCILED, _("&Unreconciled"));
if (is_nothing_selected) subGlobalOpMenuMark->Enable(MENU_TREEPOPUP_MARKUNRECONCILED, false);
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKRECONCILED, _("Reconciled"));
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKRECONCILED, _("&Reconciled"));
if (is_nothing_selected) subGlobalOpMenuMark->Enable(MENU_TREEPOPUP_MARKRECONCILED, false);
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKVOID, _("Void"));
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKVOID, _("&Void"));
if (is_nothing_selected) subGlobalOpMenuMark->Enable(MENU_TREEPOPUP_MARKVOID, false);
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARK_ADD_FLAG_FOLLOWUP, _("Follow Up"));
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARK_ADD_FLAG_FOLLOWUP, _("&Follow Up"));
if (is_nothing_selected) subGlobalOpMenuMark->Enable(MENU_TREEPOPUP_MARK_ADD_FLAG_FOLLOWUP, false);
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKDUPLICATE, _("Duplicate"));
subGlobalOpMenuMark->Append(MENU_TREEPOPUP_MARKDUPLICATE, _("D&uplicate"));
if (is_nothing_selected) subGlobalOpMenuMark->Enable(MENU_TREEPOPUP_MARKDUPLICATE, false);
menu.AppendSubMenu(subGlobalOpMenuMark, _("Mark as"));
menu.AppendSubMenu(subGlobalOpMenuMark, _("Mar&k as"));

// Disable menu items not ment for foreign transactions
if (is_foreign)
Expand Down
10 changes: 5 additions & 5 deletions src/mmframe.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1499,11 +1499,11 @@ void mmGUIFrame::showTreePopupMenu(const wxTreeItemId& id, const wxPoint& pt)

menu.AppendSeparator();
wxMenu* viewAccounts(new wxMenu);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWALL, _("All"))->Check(m_temp_view == VIEW_ACCOUNTS_ALL_STR);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWFAVORITE, _("Favorites"))->Check(m_temp_view == VIEW_ACCOUNTS_FAVORITES_STR);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWOPEN, _("Open"))->Check(m_temp_view == VIEW_ACCOUNTS_OPEN_STR);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWCLOSED, _("Closed"))->Check(m_temp_view == VIEW_ACCOUNTS_CLOSED_STR);
menu.AppendSubMenu(viewAccounts, _("Accounts Visible"));
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWALL, _("&All"))->Check(m_temp_view == VIEW_ACCOUNTS_ALL_STR);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWFAVORITE, _("&Favorites"))->Check(m_temp_view == VIEW_ACCOUNTS_FAVORITES_STR);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWOPEN, _("&Open"))->Check(m_temp_view == VIEW_ACCOUNTS_OPEN_STR);
viewAccounts->AppendRadioItem(MENU_TREEPOPUP_ACCOUNT_VIEWCLOSED, _("&Closed"))->Check(m_temp_view == VIEW_ACCOUNTS_CLOSED_STR);
menu.AppendSubMenu(viewAccounts, _("Accounts &Visible"));

PopupMenu(&menu, pt);
break;
Expand Down
6 changes: 3 additions & 3 deletions src/payeedialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -873,9 +873,9 @@ void mmPayeeDialog::OnItemRightClick(wxListEvent& event)

wxMenu mainMenu;
if (payee) mainMenu.SetTitle(payee->PAYEENAME);
mainMenu.Append(new wxMenuItem(&mainMenu, MENU_DEFINE_CATEGORY, _("Define Category")));
mainMenu.Append(new wxMenuItem(&mainMenu, MENU_DEFINE_CATEGORY, _("Define &Category")));
if (!payee) mainMenu.Enable(MENU_DEFINE_CATEGORY, false);
mainMenu.Append(new wxMenuItem(&mainMenu, MENU_REMOVE_CATEGORY, _("Remove Category")));
mainMenu.Append(new wxMenuItem(&mainMenu, MENU_REMOVE_CATEGORY, _("Remove Ca&tegory")));
if (!payee) mainMenu.Enable(MENU_REMOVE_CATEGORY, false);
mainMenu.AppendSeparator();

Expand All @@ -892,7 +892,7 @@ void mmPayeeDialog::OnItemRightClick(wxListEvent& event)
if (!payee) mainMenu.Enable(MENU_ORGANIZE_ATTACHMENTS, false);
mainMenu.AppendSeparator();

mainMenu.Append(new wxMenuItem(&mainMenu, MENU_RELOCATE_PAYEE, _("Relocate Payee")));
mainMenu.Append(new wxMenuItem(&mainMenu, MENU_RELOCATE_PAYEE, _("Merge &Payee")));
//SetToolTip(_("Change all transactions using one Payee to another Payee"));
if (!payee) mainMenu.Enable(MENU_RELOCATE_PAYEE, false);

Expand Down

0 comments on commit 2712626

Please sign in to comment.