Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shortcut hints shown in the "frequently used notes" menu on Linux #6583

Closed
ovari opened this issue Mar 14, 2024 · 9 comments
Closed
Assignees
Labels
bug fixed linux related to Linux platforms
Milestone

Comments

@ovari
Copy link
Contributor

ovari commented Mar 14, 2024

  1. New Transaction dialog
  2. Click the Notes ellipsis and the option shows Nyitva in Hungarian (should be shown in English)

image

Thank you

Money Manager Ex
• Version: 1.7.1-Beta.1 64-bit
• Built on: Mar 12 2024 03:16:33
• Database version: 19 (aes128cbc)
• Git commit: 0e99b4c2e (2024-03-11)
• Git branch: master
MMEX is using the following support products:
• wxWidgets 3.2.4 (wxGTK 3.24)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/8.5.0-DEV OpenSSL/3.1.5 zlib/1.3.1 nghttp2/1.58.0
• gettext 0.22
• apexcharts.js
Built with:
• CMake 3.28.3
• GNU Make 4.4.1
• GCC 13.2.0
Running on:
• GNOME.45 (Flatpak runtime)
• GNOME 45 (Flatpak runtime) ""
• Linux 5.15.0-100-generic x86_64
• X-Cinnamon (X11)
• System Locale: en_AU.UTF-8
• User Interface Language: en_US.UTF-8
• 1368x768 24-bit 96x96ppi
@vomikan
Copy link
Member

vomikan commented Mar 14, 2024

What values are in the notes fields? How can I reproduce this?
The fact is that the notes appear in this list as is, without translation.
image

@n-stein
Copy link
Contributor

n-stein commented Mar 14, 2024

2. Click the Notes ellipsis and the option shows Nyitva in Hungarian (should be shown in English)

This is the "Frequently Used Notes" list. It shows the 20 most frequently used notes for transactions in the account. None of these are translated, you must have entered the word "Nyitva" as a note on at least one of your transactions in that account.

Side note, I'm not sure why Linux adds the "Ctrl+O". It adds others when you have more in the list:

image

As far as I can tell, pressing that key combination does absolutely nothing, so...?

@vomikan
Copy link
Member

vomikan commented Mar 14, 2024

It seems happens becouse the ids of menu items match the service codes.

image

void mmTransDialog::OnFrequentUsedNotes(wxCommandEvent& WXUNUSED(event))
image

@n-stein
Copy link
Contributor

n-stein commented Mar 14, 2024

Perhaps we should be using wxID_HIGHEST here

https://github.com/moneymanagerex/moneymanagerex/blob/master/src%2Ftransdialog.cpp#L1136

https://github.com/moneymanagerex/moneymanagerex/blob/master/src%2Ftransdialog.cpp#L1149

n-stein added a commit to n-stein/moneymanagerex that referenced this issue Mar 15, 2024
@n-stein
Copy link
Contributor

n-stein commented Mar 15, 2024

Looks better now:

image

@n-stein n-stein changed the title Notes option shown in incorrect language Remove shortcut hints shown in the "frequently used notes" menu on Linux Mar 15, 2024
@n-stein n-stein added bug linux related to Linux platforms fixed and removed needs more info labels Mar 15, 2024
vomikan added a commit that referenced this issue Mar 15, 2024
fix(#6583): use non-reserved ids in freq notes menu
@whalley whalley added this to the v1.7.1 milestone Mar 15, 2024
@ovari
Copy link
Contributor Author

ovari commented Mar 15, 2024

Verified fixed. Thank you

The icon has also been removed. Thank you once again.

image

Money Manager Ex
• Version: 1.7.1-Beta.1 64-bit
• Built on: Mar 15 2024 20:30:16
• Database version: 19 (aes128cbc)
• Git commit: d082daa60 (2024-03-15)
• Git branch: master
MMEX is using the following support products:
• wxWidgets 3.2.4 (wxGTK 3.24)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/8.5.0-DEV OpenSSL/3.1.5 zlib/1.3.1 nghttp2/1.58.0
• gettext 0.22
• apexcharts.js
Built with:
• CMake 3.28.3
• GNU Make 4.4.1
• GCC 13.2.0
Running on:
• GNOME.45 (Flatpak runtime)
• GNOME 45 (Flatpak runtime) ""
• Linux 5.15.0-100-generic x86_64
• X-Cinnamon (X11)
• System Locale: en_AU.UTF-8
• User Interface Language: en_US.UTF-8
• 1368x768 24-bit 96x96ppi

@n-stein
Copy link
Contributor

n-stein commented Mar 20, 2024

Not quite closed. I have applied the same fix to the Scheduled Transactions dialog. Please confirm the issue is fixed there as well.

@n-stein n-stein reopened this Mar 20, 2024
@ovari
Copy link
Contributor Author

ovari commented Mar 20, 2024

Not quite closed. I have applied the same fix to the Scheduled Transactions dialog. Please confirm the issue is fixed there as well.

Once #6597 is merged can check if issue is fixed. Below is screenshot of unfixed version.

image

Money Manager Ex
• Version: 1.7.1-RC.1 64-bit
• Built on: Mar 17 2024 13:23:38
• Database version: 19 (aes128cbc)
• Git commit: d8f831b3e (2024-03-17)
• Git branch: master
MMEX is using the following support products:
• wxWidgets 3.2.4 (wxGTK 3.24)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/8.6.0-DEV OpenSSL/3.1.5 zlib/1.3.1 libidn2/2.3.4 libpsl/0.21.2 nghttp2/1.58.0
• gettext 0.22
• apexcharts.js
Built with:
• CMake 3.28.3
• GNU Make 4.4.1
• GCC 13.2.0
Running on:
• GNOME.45 (Flatpak runtime)
• GNOME 45 (Flatpak runtime) ""
• Linux 5.15.0-101-generic x86_64
• X-Cinnamon (X11)
• System Locale: en_AU.UTF-8
• User Interface Language: en_US.UTF-8
• 1368x768 24-bit 96x96ppi

@ovari
Copy link
Contributor Author

ovari commented Mar 21, 2024

Not quite closed. I have applied the same fix to the Scheduled Transactions dialog. Please confirm the issue is fixed there as well.

Fixed

Money Manager Ex
• Verzió: 1.7.1-RC.1 64 bites
• Készítési időpont: márc. 21 2024, 03:16:21
• Adatbázis verziója: 19 (aes128cbc)
• Git-végrehajtás: d478cd2e3 (2024-03-20)
• Git-ág: master
MMEX a következő támogatási termékeket használja:
• wxWidgets 3.2.4 (wxGTK 3.24)
• wxSQLite3 4.9.1 (SQLite 3.40.0)
• RapidJSON 1.1.0
• Lua 5.3.5
• libcurl/8.6.0-DEV OpenSSL/3.1.5 zlib/1.3.1 libidn2/2.3.4 libpsl/0.21.2 nghttp2/1.58.0
• gettext 0.22
• apexcharts.js
Összeállítás a következőkkel:
• CMake 3.28.3
• GNU Make 4.4.1
• GCC 13.2.0
Fut a következőn:
• GNOME.45 (Flatpak runtime)
• GNOME 45 (Flatpak runtime) ""
• Linux 5.15.0-101-generic x86_64
• X-Cinnamon (X11)
• Rendszer területi beállítása: en_AU.UTF-8
• Felhasználói felület nyelve: hu_HU.UTF-8
• 1368x768 24-bit 96x96ppi

@ovari ovari closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed linux related to Linux platforms
Projects
None yet
Development

No branches or pull requests

4 participants