Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When set the color, note is inserted #6595

Closed
3 of 11 tasks
DevelopmentAnything opened this issue Mar 20, 2024 · 3 comments
Closed
3 of 11 tasks

When set the color, note is inserted #6595

DevelopmentAnything opened this issue Mar 20, 2024 · 3 comments
Assignees
Milestone

Comments

@DevelopmentAnything
Copy link
Contributor

DevelopmentAnything commented Mar 20, 2024

MMEX version:

  • 1.6.4
  • 1.7.0
  • 1.7.1 RC1
  • 1.7.2
  • Other (please specify)

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

  • Windows
  • Mac OSX
  • Linux

Description of the bug

image

Why are notes entered automatically?

Reproduction

Is the bug reproducible?

  • Always
  • Randomly
  • Happened only once

Reproduction steps:

  1. open New/Edit Transaction Dialog
    image

  2. Click Color button and click Color item
    image

  3. you can see notes in note area

image

red color = note Item 1;
orange color = note Item 2;
yellow color = note Item 3;
...
🤣

Expected result:

Change Color Only

Actual result:

with insert Note item

Additional information

If you have a backtrace for a crash or a warning, paste it here.

n-stein added a commit to n-stein/moneymanagerex that referenced this issue Mar 20, 2024
@n-stein
Copy link
Contributor

n-stein commented Mar 20, 2024

Ah, a consequence of changes for #6583 -- the color button menu range overlaps with the note button menu range, which normally wouldn't be an issue but the event table sends all of these to the same event handler...

I have fixed it now.

whalley added a commit that referenced this issue Mar 20, 2024
fix(#6595): fix event binding for freq notes
@whalley whalley added the bug label Mar 20, 2024
@whalley whalley added the fixed label Mar 20, 2024
@whalley whalley added this to the v1.7.1 milestone Mar 20, 2024
@ovari
Copy link
Contributor

ovari commented Mar 25, 2024

@DevelopmentAnything can you verify this issue is fixed in the latest build? If so, can you please close this issue? Thank you

@DevelopmentAnything
Copy link
Contributor Author

It is necessary to ensure that the color of the button does not change in the mouse over event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants